Issue nestjs#55 - iterate library instead of chain array methods

Author: kamil.mysliwiec

CHANGELOG.md

@@ -1,5 +1,6 @@
-- Hierarchical injector. Injector improvements,
-- @Shared() decorator for scoped Modules,
+- Hierarchical injector improvements,
+- `@Shared(token?: string)` decorator for scoped Modules,
+- Added `iterare` library for applying multiple transformations to a collection,
 
 ## 1.0.0 (Final - 01.05.2017)
 

package.json

@@ -45,6 +45,7 @@
   "dependencies": {
     "cli-color": "^1.1.0",
     "express": "^4.14.0",
+    "iterare": "0.0.8",
     "json-socket": "^0.2.1",
     "redis": "^2.6.5",
     "reflect-metadata": "0.1.10",

src/core/injector/instance-loader.ts

@@ -1,3 +1,4 @@
+import iterate from 'iterare';
 import { NestContainer } from './container';
 import { Injector } from './injector';
 import { Injectable } from '../../common/interfaces/injectable.interface';
@@ -65,7 +66,7 @@ export class InstanceLoader {
 
     private callModuleInitHook(module: Module) {
         const components = [...module.routes, ...module.components];
-        components.map(([key, {instance}]) => instance)
+        iterate(components).map(([key, {instance}]) => instance)
                 .filter((instance) => !isNil(instance))
                 .filter(this.hasOnModuleInitHook)
                 .forEach((instance) => (instance as OnModuleInit).onModuleInit());

src/core/metadata-scanner.ts

@@ -1,9 +1,10 @@
+import iterate from 'iterare';
 import { Injectable } from '../common/interfaces/injectable.interface';
 import { isConstructor, isFunction, isNil } from '../common/utils/shared.utils';
 
 export class MetadataScanner {
     public scanFromPrototype<T extends Injectable, R>(instance: T, prototype, callback: (name: string) => R): R[] {
-        return Object.getOwnPropertyNames(prototype)
+        return iterate(Object.getOwnPropertyNames(prototype))
             .filter((method) => {
                 const descriptor = Object.getOwnPropertyDescriptor(prototype, method);
                 if (descriptor.set || descriptor.get) {
@@ -12,6 +13,7 @@ export class MetadataScanner {
                 return !isConstructor(method) && isFunction(prototype[method]);
             })
             .map(callback)
-            .filter((metadata) => !isNil(metadata));
+            .filter((metadata) => !isNil(metadata))
+            .toArray();
     }
 }

src/core/middlewares/middlewares-module.ts

@@ -62,9 +62,8 @@ export class MiddlewaresModule {
         const configs = this.container.getConfigs();
 
         configs.forEach((moduleConfigs, module: string) => {
-            [ ...moduleConfigs ].map((config: MiddlewareConfiguration) => {
-
-                config.forRoutes.map((route: ControllerMetadata & { method: RequestMethod }) => {
+            [ ...moduleConfigs ].forEach((config: MiddlewareConfiguration) => {
+                config.forRoutes.forEach((route: ControllerMetadata & { method: RequestMethod }) => {
                     this.setupRouteMiddleware(route, config, module, app);
                 });
             });

src/core/router/router-exception-filters.ts

@@ -1,4 +1,5 @@
 import 'reflect-metadata';
+import iterate from 'iterare';
 import { Controller } from '../../common/interfaces/controller.interface';
 import { ExceptionsHandler } from '../exceptions/exceptions-handler';
 import { EXCEPTION_FILTERS_METADATA, FILTER_CATCH_EXCEPTIONS } from '../../common/constants';
@@ -30,7 +31,7 @@ export class RouterExceptionFilters {
     }
 
     public resolveFiltersMetatypes(filters: Metatype<any>[], moduleName: string): ExceptionFilterMetadata[] {
-        return filters.filter(metatype => isFunction(metatype))
+        return iterate(filters).filter(metatype => isFunction(metatype))
                 .map(metatype => ({
                     instance: this.findExceptionsFilterInstance(metatype, moduleName),
                     metatype,
@@ -39,7 +40,8 @@ export class RouterExceptionFilters {
                 .map(({ instance, metatype }) => ({
                     func: instance.catch.bind(instance),
                     exceptionMetatypes: this.reflectCatchExceptions(metatype),
-                }));
+                }))
+                .toArray();
     }
 
     public findExceptionsFilterInstance(metatype: Metatype<any>, moduleName: string): ExceptionFilter {

src/websockets/middlewares-injector.ts

@@ -1,4 +1,5 @@
 import 'reflect-metadata';
+import iterate from 'iterare';
 import { NestContainer, InstanceWrapper } from '../core/injector/container';
 import { NestGateway } from './index';
 import { GATEWAY_MIDDLEWARES } from './constants';
@@ -27,9 +28,9 @@ export class MiddlewaresInjector {
     }
 
     public applyMiddlewares(server, components: Map<string, InstanceWrapper<Injectable>>, tokens: any[]) {
-        tokens.map(token => this.bindMiddleware(token.name, components))
+        iterate(tokens).map(token => this.bindMiddleware(token.name, components))
             .filter(middleware => !isNil(middleware))
-            .map(middleware => server.use(middleware));
+            .forEach(middleware => server.use(middleware));
     }
 
     public bindMiddleware(token: string, components: Map<string, InstanceWrapper<Injectable>>) {