Skip to content

Commit 4f8d9fe

Browse files
Merge pull request nestjs#1314 from rafalschmidt97/contributing-comments-fix
docs(contributing) fix comments issues in lists
2 parents 385071b + 7e07ef3 commit 4f8d9fe

1 file changed

Lines changed: 12 additions & 6 deletions

File tree

CONTRIBUTING.md

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
We would love for you to contribute to Nest and help make it even better than it is
44
today! As a contributor, here are the guidelines we would like you to follow:
55

6-
* [Code of Conduct](#coc)
6+
<!--* [Code of Conduct](#coc)-->
77
* [Question or Problem?](#question)
88
* [Issues and Bugs](#issue)
99
* [Feature Requests](#feature)
@@ -76,10 +76,15 @@ You can file new issues by filling out our [new issue form](https://github.com/n
7676

7777
Before you submit your Pull Request (PR) consider the following guidelines:
7878

79+
<!--
80+
To the first point
81+
82+
1. Please sign our [Contributor License Agreement (CLA)](#cla) before sending PRs.
83+
We cannot accept code without this.
84+
-->
85+
7986
1. Search [GitHub](https://github.com/nestjs/nest/pulls) for an open or closed PR
8087
that relates to your submission. You don't want to duplicate effort.
81-
<!-- 1. Please sign our [Contributor License Agreement (CLA)](#cla) before sending PRs.
82-
We cannot accept code without this. -->
8388
1. Fork the nestjs/nest repo.
8489
1. Make your changes in a new git branch:
8590

@@ -195,10 +200,11 @@ $ npm run lint
195200
196201
To ensure consistency throughout the source code, keep these rules in mind as you are working:
197202
198-
* All features or bug fixes **must be tested** by one or more specs (unit-tests).
199-
<!--
203+
<!--
200204
// We're working on auto-documentation.
201205
* All public API methods **must be documented**. (Details TBC). -->
206+
207+
* All features or bug fixes **must be tested** by one or more specs (unit-tests).
202208
* We follow [Google's JavaScript Style Guide][js-style-guide], but wrap all code at
203209
**100 characters**. An automated formatter is available, see
204210
[DEVELOPER.md](docs/DEVELOPER.md#clang-format).
@@ -272,8 +278,8 @@ There are currently a few exceptions to the "use package name" rule:
272278
* **packaging**: used for changes that change the npm package layout in all of our packages, e.g. public path changes, package.json changes done to all packages, d.ts file/format changes, changes to bundles, etc.
273279
* **changelog**: used for updating the release notes in CHANGELOG.md
274280
* **sample/#**: for the example apps directory, replacing # with the example app number
275-
<!-- * **aio**: used for docs-app (angular.io) related changes within the /aio directory of the repo -->
276281
* none/empty string: useful for `style`, `test` and `refactor` changes that are done across all packages (e.g. `style: add missing semicolons`)
282+
<!-- * **aio**: used for docs-app (angular.io) related changes within the /aio directory of the repo -->
277283
278284
### Subject
279285

0 commit comments

Comments
 (0)