feature(core) property based injection (composition)

Author: kamilmysliwiec

integration/injector/e2e/circular-modules.spec.ts

@@ -1,10 +1,9 @@
+import { Test } from '@nestjs/testing';
 import { expect } from 'chai';
-import { Test, TestingModuleBuilder } from '@nestjs/testing';
-import { INestApplication } from '@nestjs/common';
 import { CircularModule } from '../src/circular-modules/circular.module';
-import { InputService } from '../src/circular-modules/input.service';
 import { CircularService } from '../src/circular-modules/circular.service';
 import { InputModule } from '../src/circular-modules/input.module';
+import { InputService } from '../src/circular-modules/input.service';
 
 describe('Circular dependency (modules)', () => {
   it('should resolve circular dependency between providers', async () => {

integration/injector/e2e/circular-property-injection.spec.ts

@@ -0,0 +1,20 @@
+import { Test } from '@nestjs/testing';
+import { expect } from 'chai';
+import { CircularPropertiesModule } from '../src/circular-properties/circular-properties.module';
+import { CircularService } from '../src/circular-properties/circular.service';
+import { InputPropertiesModule } from '../src/circular-properties/input-properties.module';
+import { InputService } from '../src/circular-properties/input.service';
+
+describe('Circular properties dependency (modules)', () => {
+  it('should resolve circular dependency between providers', async () => {
+    const builder = Test.createTestingModule({
+      imports: [CircularPropertiesModule, InputPropertiesModule],
+    });
+    const testingModule = await builder.compile();
+    const inputService = testingModule.get<InputService>(InputService);
+    const circularService = testingModule.get<CircularService>(CircularService);
+
+    expect(inputService.service).to.be.eql(circularService);
+    expect(circularService.service).to.be.eql(inputService);
+  });
+});

integration/injector/e2e/circular.spec.ts

@@ -1,9 +1,8 @@
+import { Test } from '@nestjs/testing';
 import { expect } from 'chai';
-import { Test, TestingModuleBuilder } from '@nestjs/testing';
-import { INestApplication } from '@nestjs/common';
 import { CircularModule } from '../src/circular/circular.module';
-import { InputService } from '../src/circular/input.service';
 import { CircularService } from '../src/circular/circular.service';
+import { InputService } from '../src/circular/input.service';
 
 describe('Circular dependency', () => {
   it('should resolve circular dependency between providers', async () => {

integration/injector/e2e/injector.spec.ts

@@ -1,13 +1,14 @@
+import { RuntimeException } from '@nestjs/core/errors/exceptions/runtime.exception';
+import { UnknownExportException } from '@nestjs/core/errors/exceptions/unknown-export.exception';
+import { Test } from '@nestjs/testing';
 import { expect } from 'chai';
-import { Test, TestingModuleBuilder } from '@nestjs/testing';
-import { INestApplication } from '@nestjs/common';
+import {
+  DYNAMIC_TOKEN,
+  DYNAMIC_VALUE,
+  NestDynamicModule,
+} from '../src/dynamic/dynamic.module';
 import { ExportsModule } from '../src/exports/exports.module';
-import { TestingModule } from '@nestjs/testing/testing-module';
-import { UnknownExportException } from '@nestjs/core/errors/exceptions/unknown-export.exception';
-import { UndefinedDependencyException } from '@nestjs/core/errors/exceptions/undefined-dependency.exception';
 import { InjectModule } from '../src/inject/inject.module';
-import { RuntimeException } from '@nestjs/core/errors/exceptions/runtime.exception';
-import { NestDynamicModule, DYNAMIC_TOKEN, DYNAMIC_VALUE } from '../src/dynamic/dynamic.module';
 
 describe('Injector', () => {
   describe('when "providers" and "exports" properties are inconsistent', () => {

integration/injector/e2e/property-injection.spec.ts

@@ -0,0 +1,17 @@
+import { Test } from '@nestjs/testing';
+import { expect } from 'chai';
+import { DependencyService } from '../src/properties/dependency.service';
+import { PropertiesModule } from '../src/properties/properties.module';
+import { PropertiesService } from '../src/properties/properties.service';
+
+describe('Injector', () => {
+  it('should resolve property-based dependencies', async () => {
+    const builder = Test.createTestingModule({
+      imports: [PropertiesModule],
+    });
+    const app = await builder.compile();
+    const dependency = app.get(DependencyService);
+
+    expect(app.get(PropertiesService).service).to.be.eql(dependency);
+  });
+});

integration/injector/src/circular-properties/circular-properties.module.ts

@@ -0,0 +1,10 @@
+import { forwardRef, Module } from '@nestjs/common';
+import { CircularService } from './circular.service';
+import { InputPropertiesModule } from './input-properties.module';
+
+@Module({
+  imports: [forwardRef(() => InputPropertiesModule)],
+  providers: [CircularService],
+  exports: [CircularService],
+})
+export class CircularPropertiesModule {}

integration/injector/src/circular-properties/circular.service.ts

@@ -0,0 +1,8 @@
+import { forwardRef, Inject, Injectable } from '@nestjs/common';
+import { InputService } from './input.service';
+
+@Injectable()
+export class CircularService {
+  @Inject(forwardRef(() => InputService))
+  public readonly service: InputService;
+}

integration/injector/src/circular-properties/input-properties.module.ts

@@ -0,0 +1,10 @@
+import { forwardRef, Module } from '@nestjs/common';
+import { CircularPropertiesModule } from './circular-properties.module';
+import { InputService } from './input.service';
+
+@Module({
+  imports: [forwardRef(() => CircularPropertiesModule)],
+  providers: [InputService],
+  exports: [InputService],
+})
+export class InputPropertiesModule {}

integration/injector/src/circular-properties/input.service.ts

@@ -0,0 +1,8 @@
+import { forwardRef, Inject, Injectable } from '@nestjs/common';
+import { CircularService } from './circular.service';
+
+@Injectable()
+export class InputService {
+  @Inject(forwardRef(() => CircularService))
+  public readonly service: CircularService;
+}

integration/injector/src/properties/dependency.service.ts

@@ -0,0 +1,4 @@
+import { Injectable } from '@nestjs/common';
+
+@Injectable()
+export class DependencyService {}