tests(microservices) fix broken options unit tests

Author: kamilmysliwiec

packages/microservices/test/client/client-grpc.spec.ts

@@ -17,26 +17,28 @@ describe('ClientGrpcProxy', () => {
 
   beforeEach(() => {
     client = new ClientGrpcProxy({
-      options: {
-        protoPath: join(__dirname, './test.proto'),
-        package: 'test',
-      },
+      protoPath: join(__dirname, './test.proto'),
+      package: 'test',
     });
   });
 
   describe('getService', () => {
     describe('when "grpcClient[name]" is nil', () => {
       it('should throw "InvalidGrpcServiceException"', () => {
         (client as any).grpcClient = {};
-        expect(() => client.getService('test')).to.throw(InvalidGrpcServiceException);
+        expect(() => client.getService('test')).to.throw(
+          InvalidGrpcServiceException,
+        );
       });
     });
     describe('when "grpcClient[name]" is not nil', () => {
       it('should create grpcService', () => {
         (client as any).grpcClient = {
           test: GrpcService,
         };
-        expect(() => client.getService('test')).to.not.throw(InvalidGrpcServiceException);
+        expect(() => client.getService('test')).to.not.throw(
+          InvalidGrpcServiceException,
+        );
       });
     });
   });
@@ -90,11 +92,11 @@ describe('ClientGrpcProxy', () => {
       const methodName = 'm';
       type EvtCallback = (...args: any[]) => void;
       let callMock: {
-        on: (type: string, fn: EvtCallback) => void,
-        cancel: sinon.SinonSpy,
-        finished: boolean,
-        destroy: sinon.SinonSpy,
-        removeAllListeners: sinon.SinonSpy,
+        on: (type: string, fn: EvtCallback) => void;
+        cancel: sinon.SinonSpy;
+        finished: boolean;
+        destroy: sinon.SinonSpy;
+        removeAllListeners: sinon.SinonSpy;
       };
       let eventCallbacks: { [type: string]: EvtCallback };
       let obj;
@@ -110,7 +112,7 @@ describe('ClientGrpcProxy', () => {
         completeSpy.reset();
         eventCallbacks = {};
         callMock = {
-          on: (type, fn) => eventCallbacks[type] = fn,
+          on: (type, fn) => (eventCallbacks[type] = fn),
           cancel: sinon.spy(),
           finished: false,
           destroy: sinon.spy(),
@@ -149,9 +151,11 @@ describe('ClientGrpcProxy', () => {
         eventCallbacks.data('c');
 
         expect(callMock.cancel.called, 'should call call.cancel()').to.be.true;
-        expect(callMock.destroy.called, 'should call call.destroy()').to.be.true;
+        expect(callMock.destroy.called, 'should call call.destroy()').to.be
+          .true;
         expect(dataSpy.args).to.eql([['a'], ['b']]);
-        expect(errorSpy.called, 'should not error if client canceled').to.be.false;
+        expect(errorSpy.called, 'should not error if client canceled').to.be
+          .false;
       });
     });
   });
@@ -163,7 +167,7 @@ describe('ClientGrpcProxy', () => {
     });
     describe('on subscribe', () => {
       const methodName = 'm';
-      const obj = { [methodName]: (callback) => callback(null, {}) };
+      const obj = { [methodName]: callback => callback(null, {}) };
 
       let stream$: Observable<any>;
 
@@ -184,7 +188,9 @@ describe('ClientGrpcProxy', () => {
     describe('when package does not exist', () => {
       it('should throw "InvalidGrpcPackageException"', () => {
         sinon.stub(client, 'lookupPackage').callsFake(() => null);
-        expect(() => client.createClient()).to.throw(InvalidGrpcPackageException);
+        expect(() => client.createClient()).to.throw(
+          InvalidGrpcPackageException,
+        );
       });
     });
   });
@@ -195,7 +201,9 @@ describe('ClientGrpcProxy', () => {
         sinon.stub(client, 'getOptionsProp').callsFake(() => {
           throw new Error();
         });
-        expect(() => client.loadProto()).to.throws(InvalidProtoDefinitionException);
+        expect(() => client.loadProto()).to.throws(
+          InvalidProtoDefinitionException,
+        );
       });
     });
   });

packages/microservices/test/client/client-redis.spec.ts

@@ -301,15 +301,15 @@ describe('ClientRedis', () => {
     });
     describe('otherwise', () => {
       it('should return delay (ms)', () => {
-        (client as any).options.options = {};
+        (client as any).options = {};
         (client as any).isExplicitlyTerminated = false;
-        (client as any).options.options.retryAttempts = 3;
-        (client as any).options.options.retryDelay = 3;
+        (client as any).options.retryAttempts = 3;
+        (client as any).options.retryDelay = 3;
         const result = client.createRetryStrategy(
           { attempt: 2 } as any,
           subject,
         );
-        expect(result).to.be.eql((client as any).options.options.retryDelay);
+        expect(result).to.be.eql((client as any).options.retryDelay);
       });
     });
   });

packages/microservices/test/server/server-grpc.spec.ts

@@ -9,10 +9,8 @@ describe('ServerGrpc', () => {
   let server: ServerGrpc;
   beforeEach(() => {
     server = new ServerGrpc({
-      options: {
-        protoPath: join(__dirname, './test.proto'),
-        package: 'test',
-      },
+      protoPath: join(__dirname, './test.proto'),
+      package: 'test',
     } as any);
   });
 
@@ -167,14 +165,19 @@ describe('ServerGrpc', () => {
       it(`should close the result observable when receiving an 'cancelled' event from the client`, async () => {
         let cancelCb: () => void;
         const call = {
-          write: sinon.stub().onSecondCall().callsFake(() => cancelCb()),
+          write: sinon
+            .stub()
+            .onSecondCall()
+            .callsFake(() => cancelCb()),
           end: sinon.spy(),
-          addListener: (name, cb) => cancelCb = cb,
+          addListener: (name, cb) => (cancelCb = cb),
           removeListener: sinon.spy(),
         };
         const result$ = of(1, 2, 3);
         const callback = sinon.spy();
-        const native = sinon.stub().returns(new Promise((resolve, reject) => resolve(result$)));
+        const native = sinon
+          .stub()
+          .returns(new Promise((resolve, reject) => resolve(result$)));
 
         await server.createStreamServiceMethod(native)(call, callback);
         expect(call.write.calledTwice).to.be.true;

packages/microservices/test/server/server-redis.spec.ts

@@ -1,8 +1,7 @@
-import * as sinon from 'sinon';
 import { expect } from 'chai';
+import * as sinon from 'sinon';
 import { NO_PATTERN_MESSAGE } from '../../constants';
 import { ServerRedis } from '../../server/server-redis';
-import { Observable } from 'rxjs';
 
 describe('ServerRedis', () => {
   let server: ServerRedis;
@@ -23,7 +22,7 @@ describe('ServerRedis', () => {
         .stub(server, 'createRedisClient')
         .callsFake(() => client);
 
-        server.listen(null);
+      server.listen(null);
     });
     it('should bind "error" event to handler', () => {
       expect(onSpy.getCall(0).args[0]).to.be.equal('error');
@@ -116,7 +115,7 @@ describe('ServerRedis', () => {
   describe('getPublisher', () => {
     let publisherSpy: sinon.SinonSpy;
     let pub, publisher;
-  
+
     const id = '1';
     const pattern = 'test';
 
@@ -133,8 +132,12 @@ describe('ServerRedis', () => {
     it(`should call "publish" with expected arguments`, () => {
       const respond = 'test';
       publisher({ respond, id });
-      expect(publisherSpy.calledWith(`${pattern}_res`, JSON.stringify({ respond, id })))
-        .to.be.true;
+      expect(
+        publisherSpy.calledWith(
+          `${pattern}_res`,
+          JSON.stringify({ respond, id }),
+        ),
+      ).to.be.true;
     });
   });
   describe('deserialize', () => {
@@ -198,21 +201,21 @@ describe('ServerRedis', () => {
     describe('when ECONNREFUSED', () => {
       it('should call logger', () => {
         const loggerErrorSpy = sinon.spy((server as any).logger, 'error');
-        const result = server.createRetryStrategy(
-          { error: { code: 'ECONNREFUSED' } } as any,
-        );
+        const result = server.createRetryStrategy({
+          error: { code: 'ECONNREFUSED' },
+        } as any);
         expect(loggerErrorSpy.called).to.be.true;
       });
     });
     describe('otherwise', () => {
       it('should return delay (ms)', () => {
-        (server as any).options.options = {};
+        (server as any).options = {};
         (server as any).isExplicitlyTerminated = false;
-        (server as any).options.options.retryAttempts = 3;
-        (server as any).options.options.retryDelay = 3;
+        (server as any).options.retryAttempts = 3;
+        (server as any).options.retryDelay = 3;
         const result = server.createRetryStrategy({ attempt: 2 } as any);
-        expect(result).to.be.eql((server as any).options.options.retryDelay);
+        expect(result).to.be.eql((server as any).options.retryDelay);
       });
-    })
+    });
   });
 });

packages/microservices/test/server/server-tcp.spec.ts

@@ -1,7 +1,7 @@
-import * as sinon from 'sinon';
 import { expect } from 'chai';
-import { ServerTCP } from '../../server/server-tcp';
+import * as sinon from 'sinon';
 import { NO_PATTERN_MESSAGE } from '../../constants';
+import { ServerTCP } from '../../server/server-tcp';
 
 describe('ServerTCP', () => {
   let server: ServerTCP;
@@ -100,14 +100,14 @@ describe('ServerTCP', () => {
     });
     describe('otherwise', () => {
       it('should return delay (ms)', () => {
-        (server as any).options.options = {};
+        (server as any).options = {};
         (server as any).isExplicitlyTerminated = false;
-        (server as any).options.options.retryAttempts = 3;
+        (server as any).options.retryAttempts = 3;
         (server as any).retryAttemptsCount = 2;
-        (server as any).options.options.retryDelay = 3;
+        (server as any).options.retryDelay = 3;
         const result = server.handleClose();
         expect(result).to.be.not.undefined;
       });
-    })
+    });
   });
 });