removed set header code before running interceptors. Added e2e test for testing header override.

Author: toonvanstrijp

integration/hello-world/e2e/interceptors.spec.ts

@@ -41,6 +41,19 @@ export class StatusInterceptor {
   }
 }
 
+@Injectable()
+export class HeaderInterceptor {
+
+  constructor(private authorization: string){}
+
+  intercept(context: ExecutionContext, next: CallHandler) {
+    const ctx = context.switchToHttp();
+    const res = ctx.getResponse();
+    res.header('Authorization', this.authorization);
+    return next.handle().pipe(map(data => ({ data })));
+  }
+}
+
 function createTestModule(interceptor) {
   return Test.createTestingModule({
     imports: [ApplicationModule],
@@ -111,6 +124,18 @@ describe('Interceptors', () => {
       .expect(400, { data: 'Hello world!' });
   });
 
+  it(`should modify Authorization header`, async () => {
+    app = (await createTestModule(
+      new HeaderInterceptor('jwt'),
+    )).createNestApplication();
+
+    await app.init();
+    return request(app.getHttpServer())
+      .get('/hello')
+      .expect(200)
+      .expect('Authorization', 'jwt');
+  });
+
   afterEach(async () => {
     await app.close();
   });

packages/core/router/router-execution-context.ts

@@ -139,6 +139,12 @@ export class RouterExecutionContext {
 
       this.responseController.status(res, httpStatusCode);
 
+      const responseHeaders = this.reflectResponseHeaders(callback);
+      const hasCustomHeaders = !isEmpty(responseHeaders);
+
+      hasCustomHeaders &&
+        this.responseController.setHeaders(res, responseHeaders);
+
       const result = await this.interceptorsConsumer.intercept(
         interceptors,
         [req, res],
@@ -347,19 +353,13 @@ export class RouterExecutionContext {
     httpStatusCode?: number
   ) {
     const renderTemplate = this.reflectRenderTemplate(callback);
-    const responseHeaders = this.reflectResponseHeaders(callback);
-    const hasCustomHeaders = !isEmpty(responseHeaders);
 
     if (renderTemplate) {
       return async <TResult, TResponse>(result: TResult, res: TResponse) => {
-        hasCustomHeaders &&
-          this.responseController.setHeaders(res, responseHeaders);
         await this.responseController.render(result, res, renderTemplate);
       };
     }
     return async <TResult, TResponse>(result: TResult, res: TResponse) => {
-      hasCustomHeaders &&
-        this.responseController.setHeaders(res, responseHeaders);
       result = await this.responseController.transformToResult(result);
       !isResponseHandled &&
         (await this.responseController.apply(result, res, httpStatusCode));