Merge pull request nestjs#1103 from jbpionnier/refactor/enable_strict_mode

refactor(nestjs) enable strict mode

Author: kamilmysliwiec

packages/common/pipes/validation.pipe.ts

@@ -17,7 +17,7 @@ let classTransformer: any = {};
 @Injectable()
 export class ValidationPipe implements PipeTransform<any> {
   protected isTransformEnabled: boolean;
-  protected isDetailedOutputDisabled: boolean;
+  protected isDetailedOutputDisabled?: boolean;
   protected validatorOptions: ValidatorOptions;
 
   constructor(@Optional() options?: ValidationPipeOptions) {

packages/common/services/logger.service.ts

@@ -13,9 +13,9 @@ export interface LoggerService {
 
 @Injectable()
 export class Logger implements LoggerService {
-  private static prevTimestamp = null;
+  private static prevTimestamp?: number;
   private static contextEnvironment = NestEnvironment.RUN;
-  private static logger: typeof Logger | LoggerService = Logger;
+  private static logger?: typeof Logger | LoggerService = Logger;
   private static readonly yellow = clc.xterm(3);
 
   constructor(
@@ -52,7 +52,7 @@ export class Logger implements LoggerService {
   }
 
   static overrideLogger(logger: LoggerService | boolean) {
-    this.logger = logger ? (logger as LoggerService) : null;
+    this.logger = logger ? (logger as LoggerService) : undefined;
   }
 
   static setMode(mode: NestEnvironment) {

packages/common/tsconfig.json

@@ -12,6 +12,8 @@
     "sourceMap": false,
     "allowJs": false,
     "rootDir": "./",
+    "strict": true,
+    "strictNullChecks": false,
     "outDir": "../../node_modules/@nestjs/common"
   },
   "include": [

packages/core/injector/module.ts

@@ -241,7 +241,7 @@ export class Module {
   }
 
   public addCustomClass(component: CustomClass, collection: Map<string, any>) {
-    const { provide, name, useClass } = component;
+    const { name, useClass } = component;
     collection.set(name, {
       name,
       metatype: useClass,
@@ -251,7 +251,7 @@ export class Module {
   }
 
   public addCustomValue(component: CustomValue, collection: Map<string, any>) {
-    const { provide, name, useValue: value } = component;
+    const { name, useValue: value } = component;
     collection.set(name, {
       name,
       metatype: null,
@@ -266,7 +266,7 @@ export class Module {
     component: CustomFactory,
     collection: Map<string, any>,
   ) {
-    const { provide, name, useFactory: factory, inject } = component;
+    const { name, useFactory: factory, inject } = component;
     collection.set(name, {
       name,
       metatype: factory as any,

packages/core/middleware/middleware-module.ts

@@ -107,10 +107,10 @@ export class MiddlewareModule {
   ) {
     const { forRoutes } = config;
     await Promise.all(
-      forRoutes.map(async (routeInfo: RouteInfo) => {
+      forRoutes.map(async (routeInfo: Type<any> | string | RouteInfo) => {
         await this.registerRouteMiddleware(
           middlewareContainer,
-          routeInfo,
+          routeInfo as RouteInfo,
           config,
           module,
           applicationRef,

packages/core/nest-application.ts

@@ -27,6 +27,7 @@ import * as http from 'http';
 import * as https from 'https';
 import iterate from 'iterare';
 import * as optional from 'optional';
+import { RequestHandler } from '../common/interfaces';
 import { ExpressAdapter } from './adapters/express-adapter';
 import { FastifyAdapter } from './adapters/fastify-adapter';
 import { ApplicationConfig } from './application-config';
@@ -286,7 +287,7 @@ export class NestApplication extends NestApplicationContext
   }
 
   public enableCors(options?: CorsOptions): this {
-    this.httpAdapter.use(cors(options));
+    this.httpAdapter.use(cors(options) as RequestHandler);
     return this;
   }
 

packages/core/tsconfig.json

@@ -12,7 +12,10 @@
     "sourceMap": false,
     "allowJs": false,
     "rootDir": "./",
-    "baseUrl": "./../../",
+    "baseUrl": "../../",
+    "strict": true,
+    "strictNullChecks": false,
+    "noImplicitThis": false,
     "outDir": "../../node_modules/@nestjs/core"
   },
   "include": [

packages/microservices/tsconfig.json

@@ -11,7 +11,9 @@
     "target": "es2017",
     "sourceMap": false,
     "allowJs": false,
-    "baseUrl": "./../../",
+    "baseUrl": "../../",
+    "strict": true,
+    "strictNullChecks": false,
     "outDir": "../../node_modules/@nestjs/microservices"
   },
   "include": [

packages/testing/tsconfig.json

@@ -11,7 +11,8 @@
     "target": "es2017",
     "sourceMap": false,
     "allowJs": false,
-    "baseUrl": "./../../",
+    "baseUrl": "../../",
+    "strict": true,
     "outDir": "../../node_modules/@nestjs/testing"
   },
   "include": [

packages/websockets/tsconfig.json

@@ -11,7 +11,9 @@
     "target": "es2017",
     "sourceMap": false,
     "allowJs": false,
-    "baseUrl": "./../../",
+    "baseUrl": "../../",
+    "strict": true,
+    "strictNullChecks": false,
     "outDir": "../../node_modules/@nestjs/websockets"
   },
   "include": [