test: use url class instead of request options

Author: jmcdo29

integration/send-files/e2e/express.spec.ts

@@ -75,9 +75,9 @@ describe('Express FileSend', () => {
   });
   it('should allow for the client to end the response and be able to make another', async () => {
     await app.listen(0);
-    const httpOptions = await getHttpBaseOptions(app);
-    await sendCanceledHttpRequest(httpOptions, '/file/slow');
-    const res = await sendHttpRequest(httpOptions, '/file/stream');
+    const url = await getHttpBaseOptions(app);
+    await sendCanceledHttpRequest(new URL('/file/slow', url));
+    const res = await sendHttpRequest(new URL('/file/stream', url));
     expect(res.statusCode).to.be.eq(200);
   }).timeout(5000);
 });

integration/send-files/e2e/utils.ts

@@ -1,28 +1,17 @@
 import { INestApplication } from '@nestjs/common';
 import { IncomingMessage, request, RequestOptions } from 'http';
+import { URL } from 'url';
 
 export const getHttpBaseOptions = async (
   app: INestApplication,
-): Promise<RequestOptions> => {
+): Promise<URL> => {
   const url = await app.getUrl();
-  // replace IPv6 localhost with IPv4 localhost alias and split URL on : to get the protocol (http), the host (localhost) and the port (random port)
-  const [protocol, host, port] = url.replace('[::1]', 'localhost').split(':');
-  return {
-    // protocol is expected to be http: or https:
-    protocol: `${protocol}:`,
-    // remove the // prefix left over from the split(':')
-    host: host.replace('//', ''),
-    port,
-    method: 'GET',
-  };
+  return new URL(url);
 };
 
-export const sendCanceledHttpRequest = async (
-  options: RequestOptions,
-  path: string,
-) => {
+export const sendCanceledHttpRequest = async (url: URL) => {
   return new Promise((resolve, reject) => {
-    const req = request({ ...options, path }, res => {
+    const req = request(url, res => {
       // close the request once we get the first response of data
       res.on('data', () => {
         req.destroy();
@@ -35,12 +24,9 @@ export const sendCanceledHttpRequest = async (
   });
 };
 
-export const sendHttpRequest = async (
-  options: RequestOptions,
-  path: string,
-) => {
+export const sendHttpRequest = async (url: URL) => {
   return new Promise<IncomingMessage>((resolve, reject) => {
-    const req = request({ ...options, path }, res => {
+    const req = request(url, res => {
       // this makes sure that the response actually starts and is read. We could verify this value against the same
       // that is in an earlier test, but all we care about in _this_ test is that the status code is 200
       res.on('data', chunk => {