Skip to content

Commit 93c25a3

Browse files
Merge pull request nestjs#10 from kamilmysliwiec/update-rc8
RC.8 fixes
2 parents 7cfca52 + b0e8d5f commit 93c25a3

2 files changed

Lines changed: 5 additions & 13 deletions

File tree

src/core/middlewares/builder.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,10 @@ export class MiddlewareBuilder {
1616
resolveParams = data;
1717
return configProxy as MiddlewareConfigProxy;
1818
},
19-
forRoutes: (routes) => {
20-
if (isUndefined(routes)) {
21-
throw new InvalidMiddlewareConfigurationException();
22-
}
19+
forRoutes: (...routes) => {
2320
const configuration = {
2421
middlewares: this.bindValuesToResolve(metatypes, resolveParams),
25-
forRoutes: [].concat(routes)
22+
forRoutes: routes
2623
};
2724
this.middlewaresCollection.add(<MiddlewareConfiguration>configuration);
2825
return this;
@@ -62,5 +59,5 @@ export class MiddlewareBuilder {
6259

6360
export interface MiddlewareConfigProxy {
6461
with: (...data) => MiddlewareConfigProxy;
65-
forRoutes: (routes) => MiddlewareBuilder;
62+
forRoutes: (...routes) => MiddlewareBuilder;
6663
}

src/core/test/middlewares/builder.spec.ts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,17 +22,12 @@ describe('MiddlewareBuilder', () => {
2222
});
2323
describe('when "forRoutes()" called', () => {
2424
class Test {}
25-
it('should throws "InvalidMiddlewareConfigurationException" when passed argument is undefined', () => {
26-
expect(() => configProxy.forRoutes()).to.throws(
27-
InvalidMiddlewareConfigurationException
28-
);
29-
});
3025
it('should store configuration passed as argument', () => {
31-
configProxy.forRoutes(Test);
26+
configProxy.forRoutes(Test, 'test');
3227

3328
expect(builder.build()).to.deep.equal([{
3429
middlewares: [],
35-
forRoutes: [ Test ]
30+
forRoutes: [ Test, 'test' ]
3631
}]);
3732
});
3833
});

0 commit comments

Comments
 (0)