Address styling concerns

Author: Sieabah

packages/common/exceptions/http.exception.ts

@@ -31,7 +31,7 @@ export class HttpException extends Error {
     return this.status;
   }
 
-  private getErrorString(target: string | object) {
+  private getErrorString(target: string | object): string{
     if (typeof target === 'string') {
       return target;
     }

packages/common/test/exceptions/http.exception.spec.ts

@@ -45,26 +45,28 @@ describe('HttpException', () => {
     });
   });
 
-  it('Should inherit from error', () => {
+  it('should inherit from error', () => {
     const error = new HttpException('', 400);
     expect(error instanceof Error).to.be.true;
   });
 
-  it('Should be serializable', () => {
+  it('should be serializable', () => {
     const message = 'Some Error';
     const error = new HttpException(message, 400);
     expect(`${error}`).to.be.eql(`Error: ${message}`);
   });
 
-  it('Should serialize objects', () => {
-    const obj = { foo: 'bar' };
-    const error = new HttpException(obj, 400);
-    expect(`${error}`).to.be.eql(`Error: ${JSON.stringify(obj)}`);
-    expect(`${error}`.includes('[object Object]')).to.not.be.true;
-  });
+  describe('when "message" is an object', () => {
+    it('should serialize an object', () => {
+      const obj = { foo: 'bar' };
+      const error = new HttpException(obj, 400);
+      expect(`${error}`).to.be.eql(`Error: ${JSON.stringify(obj)}`);
+      expect(`${error}`.includes('[object Object]')).to.not.be.true;
+    });
 
-  it('Should serialize sub errors', () => {
-    const error = new NotFoundException();
-    expect(`${error}`.includes('Not Found')).to.be.true;
+    it('should serialize sub errors', () => {
+      const error = new NotFoundException();
+      expect(`${error}`.includes('Not Found')).to.be.true;
+    });
   });
 });

packages/microservices/exceptions/rpc-exception.ts

@@ -9,7 +9,7 @@ export class RpcException extends Error {
     return this.error;
   }
 
-  private getErrorString(target) {
+  private getErrorString(target: string | object): string {
     if (typeof target === 'string') {
       return target;
     }

packages/microservices/test/exceptions/rpc-exception.spec.ts

@@ -12,7 +12,7 @@ describe('RpcException', () => {
     expect(instance.getError()).to.be.eql(error);
   });
 
-  it('Should serialize', () => {
+  it('should serialize', () => {
     expect(`${instance}`.includes(error)).to.be.true;
     const obj = {foo: 'bar'};
     expect(`${new RpcException(obj)}`.includes(JSON.stringify(obj))).to.be.true;

packages/websockets/errors/ws-exception.ts

@@ -10,7 +10,7 @@ export class WsException extends Error {
     return this.error;
   }
 
-  private getErrorString(target) {
+  private getErrorString(target: string | object): string {
     if (typeof target === 'string') {
       return target;
     }

packages/websockets/test/exceptions/ws-exception.spec.ts

@@ -12,7 +12,7 @@ describe('WsException', () => {
     expect(instance.getError()).to.be.eql(error);
   });
 
-  it('Should serialize', () => {
+  it('should serialize', () => {
     expect(`${instance}`.includes(error)).to.be.true;
     const obj = {foo: 'bar'};
     expect(`${new WsException(obj)}`.includes(JSON.stringify(obj))).to.be.true;