test(websockets): fix expect that does not execute

Author: tonyhallett

packages/websockets/test/web-sockets-controller.spec.ts

@@ -31,7 +31,7 @@ describe('WebSocketsController', () => {
   let provider: SocketServerProvider,
     config: ApplicationConfig,
     mockProvider: sinon.SinonMock;
-
+  const messageHandlerCallback = () => Promise.resolve();
   const port = 90,
     namespace = '/';
   @WebSocketGateway(port, { namespace })
@@ -41,10 +41,12 @@ describe('WebSocketsController', () => {
     config = new ApplicationConfig(new NoopAdapter());
     provider = new SocketServerProvider(null, config);
     mockProvider = sinon.mock(provider);
+    const contextCreator = sinon.createStubInstance(WsContextCreator);
+    contextCreator.create.returns(messageHandlerCallback);
     instance = new WebSocketsController(
       provider,
       config,
-      sinon.createStubInstance(WsContextCreator) as any,
+      contextCreator as any,
     );
   });
   describe('mergeGatewayAndServer', () => {
@@ -91,14 +93,21 @@ describe('WebSocketsController', () => {
       server,
       hookServerToProperties: sinon.SinonSpy,
       subscribeEvents: sinon.SinonSpy;
+    const handlerCallback = () => {};
 
     beforeEach(() => {
       gateway = new Test();
       explorer = new GatewayMetadataExplorer(new MetadataScanner());
       mockExplorer = sinon.mock(explorer);
       (instance as any).metadataExplorer = explorer;
 
-      handlers = ['test'];
+      handlers = [
+        {
+          message: 'message',
+          methodName: 'methodName',
+          callback: handlerCallback,
+        },
+      ];
       server = { server: 'test' };
 
       mockExplorer.expects('explore').returns(handlers);
@@ -115,7 +124,15 @@ describe('WebSocketsController', () => {
     });
     it('should call "subscribeEvents" with expected arguments', () => {
       instance.subscribeToServerEvents(gateway, namespace, port, '');
-      expect(subscribeEvents.calledWith(gateway, handlers, server));
+      expect(subscribeEvents.firstCall.args[0]).to.be.equal(gateway);
+      expect(subscribeEvents.firstCall.args[2]).to.be.equal(server);
+      expect(subscribeEvents.firstCall.args[1]).to.be.eql([
+        {
+          message: 'message',
+          methodName: 'methodName',
+          callback: messageHandlerCallback,
+        },
+      ]);
     });
   });
   describe('subscribeEvents', () => {
@@ -321,9 +338,9 @@ describe('WebSocketsController', () => {
         it('should returns Promise<Observable>', async () => {
           const value = 100;
           expect(
-            await (await instance.pickResult(
-              Promise.resolve(Promise.resolve(value)),
-            )).toPromise(),
+            await (
+              await instance.pickResult(Promise.resolve(Promise.resolve(value)))
+            ).toPromise(),
           ).to.be.eq(100);
         });
       });
@@ -332,9 +349,9 @@ describe('WebSocketsController', () => {
         it('should returns Promise<Observable>', async () => {
           const value = 100;
           expect(
-            await (await instance.pickResult(
-              Promise.resolve(of(value)),
-            )).toPromise(),
+            await (
+              await instance.pickResult(Promise.resolve(of(value)))
+            ).toPromise(),
           ).to.be.eq(100);
         });
       });
@@ -343,9 +360,9 @@ describe('WebSocketsController', () => {
         it('should returns Promise<Observable>', async () => {
           const value = 100;
           expect(
-            await (await instance.pickResult(
-              Promise.resolve(value),
-            )).toPromise(),
+            await (
+              await instance.pickResult(Promise.resolve(value))
+            ).toPromise(),
           ).to.be.eq(100);
         });
       });