bugfix(@nestjs/common) fix custom decorators (data isnt always string)

Author: kamilmysliwiec

packages/common/decorators/http/create-route-param-metadata.decorator.ts

@@ -6,7 +6,7 @@ import {
 import { PipeTransform } from '../../index';
 import { Type } from '../../interfaces';
 import { CustomParamFactory } from '../../interfaces/features/custom-route-param-factory.interface';
-import { isNil, isString } from '../../utils/shared.utils';
+import { isFunction, isNil } from '../../utils/shared.utils';
 import { ParamData, RouteParamsMetadata } from './route-params.decorator';
 
 const assignCustomMetadata = (
@@ -51,7 +51,11 @@ export function createParamDecorator(
     const args =
       Reflect.getMetadata(ROUTE_ARGS_METADATA, target.constructor, key) || {};
 
-    const hasParamData = isNil(data) || isString(data);
+    const isPipe = pipe =>
+      pipe &&
+      ((isFunction(pipe) && pipe.prototype) || isFunction(pipe.transform));
+
+    const hasParamData = isNil(data) || !isPipe(data);
     const paramData = hasParamData ? data : undefined;
     const paramPipes = hasParamData ? pipes : [data, ...pipes];
 

packages/common/test/decorators/create-route-param-metadata.spec.ts

@@ -18,15 +18,15 @@ describe('createRouteParamDecorator', () => {
     const Decorator = createRouteParamDecorator(factoryFn);
 
     describe('when 0 pipes have been passed', () => {
-      const data = 'test';
+      const data = { data: 'test' };
       class Test {
         public test(@Decorator(data) param) {}
       }
       it('should enhance param with "data"', () => {
         const metadata = Reflect.getMetadata(ROUTE_ARGS_METADATA, Test, 'test');
         const key = Object.keys(metadata)[0];
         expect(metadata[key]).to.be.eql({
-          data: 'test',
+          data,
           factory: factoryFn,
           index: 0,
           pipes: [],
@@ -44,6 +44,8 @@ describe('createRouteParamDecorator', () => {
         ) {}
 
         public testNoData(@Decorator(pipe) param) {}
+
+        public testNoDataClass(@Decorator(ParseIntPipe) param) {}
       }
       it('should enhance param with "data" and ParseIntPipe', () => {
         const metadata = Reflect.getMetadata(ROUTE_ARGS_METADATA, Test, 'test');
@@ -70,6 +72,21 @@ describe('createRouteParamDecorator', () => {
           pipes: [pipe],
         });
       });
+
+      it('should enhance param with ParseIntPipe metatype', () => {
+        const metadata = Reflect.getMetadata(
+          ROUTE_ARGS_METADATA,
+          Test,
+          'testNoDataClass',
+        );
+        const key = Object.keys(metadata)[0];
+        expect(metadata[key]).to.be.eql({
+          data: undefined,
+          factory: factoryFn,
+          index: 0,
+          pipes: [ParseIntPipe],
+        });
+      });
     });
   });
 });