fix(core): assing unique id to module token

Author: kamilmysliwiec

packages/core/injector/module-token-factory.ts

@@ -1,18 +1,23 @@
 import { DynamicModule } from '@nestjs/common';
 import { SHARED_MODULE_METADATA } from '@nestjs/common/constants';
 import { Type } from '@nestjs/common/interfaces/type.interface';
+import { randomStringGenerator } from '@nestjs/common/utils/random-string-generator.util';
 import stringify from 'fast-safe-stringify';
 import * as hash from 'object-hash';
 
 export class ModuleTokenFactory {
+  private readonly moduleIdsCache = new WeakMap<Type<unknown>, string>();
+
   public create(
-    metatype: Type<any>,
-    scope: Type<any>[],
+    metatype: Type<unknown>,
+    scope: Type<unknown>[],
     dynamicModuleMetadata?: Partial<DynamicModule> | undefined,
   ): string {
+    const moduleId = this.getModuleId(metatype);
     const moduleScope = this.reflectScope(metatype);
     const isSingleScoped = moduleScope === true;
     const opaqueToken = {
+      id: moduleId,
       module: this.getModuleName(metatype),
       dynamic: this.getDynamicMetadataToken(dynamicModuleMetadata),
       scope: isSingleScoped ? this.getScopeStack(scope) : moduleScope,
@@ -45,6 +50,16 @@ export class ModuleTokenFactory {
     return stack.map(module => module.name);
   }
 
+  public getModuleId(metatype: Type<unknown>): string {
+    let moduleId = this.moduleIdsCache.get(metatype);
+    if (moduleId) {
+      return moduleId;
+    }
+    moduleId = randomStringGenerator();
+    this.moduleIdsCache.set(metatype, moduleId);
+    return moduleId;
+  }
+
   public getModuleName(metatype: Type<any>): string {
     return metatype.name;
   }

packages/core/test/injector/module-token-factory.spec.ts

@@ -1,13 +1,17 @@
 import { expect } from 'chai';
 import stringify from 'fast-safe-stringify';
 import * as hash from 'object-hash';
+import * as sinon from 'sinon';
 import { SingleScope } from '../../../common';
 import { ModuleTokenFactory } from '../../injector/module-token-factory';
 
 describe('ModuleTokenFactory', () => {
+  const moduleId = 'constId';
   let factory: ModuleTokenFactory;
+
   beforeEach(() => {
     factory = new ModuleTokenFactory();
+    sinon.stub(factory, 'getModuleId').returns(moduleId);
   });
   describe('create', () => {
     class Module {}
@@ -16,6 +20,7 @@ describe('ModuleTokenFactory', () => {
       const token = factory.create(Module as any, [Module], undefined);
       expect(token).to.be.deep.eq(
         hash({
+          id: moduleId,
           module: Module.name,
           dynamic: '',
           scope,
@@ -27,6 +32,7 @@ describe('ModuleTokenFactory', () => {
       const token = factory.create(type, [Module], undefined);
       expect(token).to.be.deep.eq(
         hash({
+          id: moduleId,
           module: Module.name,
           dynamic: '',
           scope: [Module.name],
@@ -40,6 +46,7 @@ describe('ModuleTokenFactory', () => {
       } as any);
       expect(token).to.be.deep.eq(
         hash({
+          id: moduleId,
           module: Module.name,
           dynamic: stringify({
             providers: [{}],