fix() fix default param metadata (rpc & websockets)

Author: kamilmysliwiec

packages/microservices/context/rpc-context-creator.ts

@@ -27,6 +27,7 @@ import { PARAM_ARGS_METADATA } from '../constants';
 import { RpcException } from '../exceptions';
 import { RpcParamsFactory } from '../factories/rpc-params-factory';
 import { ExceptionFiltersContext } from './exception-filters-context';
+import { DEFAULT_CALLBACK_METADATA } from './rpc-metadata-constants';
 import { RpcProxy } from './rpc-proxy';
 
 type RpcParamProperties = ParamProperties & { metatype?: any };
@@ -173,8 +174,8 @@ export class RpcContextCreator {
       this.contextUtils.reflectCallbackMetadata<T>(
         instance,
         methodName,
-        PARAM_ARGS_METADATA || '',
-      ) || {};
+        PARAM_ARGS_METADATA,
+      ) || DEFAULT_CALLBACK_METADATA;
     const keys = Object.keys(metadata);
     const argsLength = this.contextUtils.getArgumentsLength(keys, metadata);
     const paramtypes = this.contextUtils.reflectCallbackParamtypes(

packages/microservices/context/rpc-metadata-constants.ts

@@ -0,0 +1,6 @@
+import { RpcParamtype } from '../enums/rpc-paramtype.enum';
+
+export const DEFAULT_CALLBACK_METADATA = {
+  [`${RpcParamtype.CONTEXT}:1`]: { index: 1, data: undefined, pipes: [] },
+  [`${RpcParamtype.PAYLOAD}:0`]: { index: 0, data: undefined, pipes: [] },
+};

packages/microservices/enums/rpc-paramtype.enum.ts

@@ -1,4 +1,4 @@
 export enum RpcParamtype {
-  PAYLOAD = 0,
-  CONTEXT = 1,
+  PAYLOAD = 3,
+  CONTEXT = 4,
 }

packages/microservices/test/context/rpc-context-creator.spec.ts

@@ -179,6 +179,7 @@ describe('RpcContextCreator', () => {
       ];
       expect(values[0]).to.deep.include(expectedValues[0]);
       expect(values[1]).to.deep.include(expectedValues[1]);
+      expect(values[2]).to.deep.include(expectedValues[2]);
     });
   });
   describe('getParamValue', () => {

packages/websockets/context/ws-context-creator.ts

@@ -25,6 +25,7 @@ import { PARAM_ARGS_METADATA } from '../constants';
 import { WsException } from '../errors/ws-exception';
 import { WsParamsFactory } from '../factories/ws-params-factory';
 import { ExceptionFiltersContext } from './exception-filters-context';
+import { DEFAULT_CALLBACK_METADATA } from './ws-metadata-constants';
 import { WsProxy } from './ws-proxy';
 
 type WsParamProperties = ParamProperties & { metatype?: any };
@@ -153,8 +154,8 @@ export class WsContextCreator {
       this.contextUtils.reflectCallbackMetadata<T>(
         instance,
         methodName,
-        PARAM_ARGS_METADATA || '',
-      ) || {};
+        PARAM_ARGS_METADATA,
+      ) || DEFAULT_CALLBACK_METADATA;
     const keys = Object.keys(metadata);
     const argsLength = this.contextUtils.getArgumentsLength(keys, metadata);
     const paramtypes = this.contextUtils.reflectCallbackParamtypes(

packages/websockets/context/ws-metadata-constants.ts

@@ -0,0 +1,6 @@
+import { WsParamtype } from '../enums/ws-paramtype.enum';
+
+export const DEFAULT_CALLBACK_METADATA = {
+  [`${WsParamtype.PAYLOAD}:1`]: { index: 1, data: undefined, pipes: [] },
+  [`${WsParamtype.SOCKET}:0`]: { index: 0, data: undefined, pipes: [] },
+};

packages/websockets/enums/ws-paramtype.enum.ts

@@ -1,4 +1,4 @@
 export enum WsParamtype {
   SOCKET = 0,
-  PAYLOAD = 1,
+  PAYLOAD = 3,
 }