feature(@nestjs/core) use generator instead of local variable

Author: kamilmysliwiec

src/core/metadata-scanner.ts

@@ -12,27 +12,26 @@ export class MetadataScanner {
     prototype,
     callback: (name: string) => R,
   ): R[] {
-    return iterate(this.getAllFilteredMethodNames_(prototype))
+    return iterate([...this.getAllFilteredMethodNames(prototype)])
       .map(callback)
       .filter(metadata => !isNil(metadata))
       .toArray();
   }
 
-  private getAllFilteredMethodNames_(prototype): string[] {
-    let methods: string[] = [];
+  *getAllFilteredMethodNames(prototype): IterableIterator<string> {
     do {
-      iterate(Object.getOwnPropertyNames(prototype))
-      .filter(prop => {
-        const descriptor = Object.getOwnPropertyDescriptor(prototype, prop);
-        if (descriptor.set || descriptor.get) {
-          return false;
-        }
-        return !isConstructor(prop) && isFunction(prototype[prop]);
-      })
-      .forEach(method => {
-        methods.push(method);
-      });
-    } while ((prototype = Reflect.getPrototypeOf(prototype)) && prototype != Object.prototype)
-    return methods;
+      yield* iterate(Object.getOwnPropertyNames(prototype))
+        .filter(prop => {
+          const descriptor = Object.getOwnPropertyDescriptor(prototype, prop);
+          if (descriptor.set || descriptor.get) {
+            return false;
+          }
+          return !isConstructor(prop) && isFunction(prototype[prop]);
+        })
+        .toArray()
+    } while (
+      (prototype = Reflect.getPrototypeOf(prototype)) &&
+      prototype != Object.prototype
+    );
   }
 }