test(nestjs) bump test coverage

Author: kamilmysliwiec

package.json

@@ -1,25 +1,34 @@
 {
   "name": "nestjs",
-  "version": "5.3.15",
+  "version": "5.4.0",
   "description": "Modern, fast, powerful node.js web framework",
   "scripts": {
     "coverage": "nyc report --reporter=text-lcov | coveralls",
     "precommit": "lint-staged",
-    "test": "nyc --require ts-node/register mocha packages/**/*.spec.ts --reporter spec --require 'node_modules/reflect-metadata/Reflect.js'",
-    "integration-test": "mocha integration/**/*.spec.ts --reporter spec --require ts-node/register --require 'node_modules/reflect-metadata/Reflect.js'",
-    "lint": "tslint -p tsconfig.json -c tslint.json \"packages/**/*.ts\" -e \"*.spec.ts\"",
-    "format": "prettier **/**/*.ts --ignore-path ./.prettierignore --write && git status",
+    "test":
+      "nyc --require ts-node/register mocha packages/**/*.spec.ts --reporter spec --require 'node_modules/reflect-metadata/Reflect.js'",
+    "integration-test":
+      "mocha integration/**/*.spec.ts --reporter spec --require ts-node/register --require 'node_modules/reflect-metadata/Reflect.js'",
+    "lint":
+      "tslint -p tsconfig.json -c tslint.json \"packages/**/*.ts\" -e \"*.spec.ts\"",
+    "format":
+      "prettier **/**/*.ts --ignore-path ./.prettierignore --write && git status",
     "clean": "gulp clean:bundle",
     "build": "npm run clean && gulp build",
     "prebuild:dev": "rm -rf node_modules/@nestjs",
     "build:dev": "gulp build --dist node_modules/@nestjs && gulp move",
     "postinstall": "opencollective",
     "prerelease": "gulp copy-misc && gulp build --dist node_modules/@nestjs",
-    "publish": "npm run prerelease && npm run build && ./node_modules/.bin/lerna publish --force-publish --exact -m \"chore(@nestjs) publish %s release\"",
-    "publish:rc": "npm run prerelease && npm run build && ./node_modules/.bin/lerna publish --npm-tag=rc -m \"chore(@nestjs) publish %s release\"",
-    "publish:next": "npm run prerelease && npm run build && ./node_modules/.bin/lerna publish --npm-tag=next --skip-git -m \"chore(@nestjs) publish %s release\"",
-    "publish:beta": "npm run prerelease && npm run build && ./node_modules/.bin/lerna publish --npm-tag=beta -m \"chore(@nestjs) publish %s release\"",
-    "publish:test": "npm run prerelease && npm run build && ./node_modules/.bin/lerna publish --force-publish --npm-tag=test --skip-git -m \"chore(@nestjs) publish %s release\""
+    "publish":
+      "npm run prerelease && npm run build && ./node_modules/.bin/lerna publish --force-publish --exact -m \"chore(@nestjs) publish %s release\"",
+    "publish:rc":
+      "npm run prerelease && npm run build && ./node_modules/.bin/lerna publish --npm-tag=rc -m \"chore(@nestjs) publish %s release\"",
+    "publish:next":
+      "npm run prerelease && npm run build && ./node_modules/.bin/lerna publish --npm-tag=next --skip-git -m \"chore(@nestjs) publish %s release\"",
+    "publish:beta":
+      "npm run prerelease && npm run build && ./node_modules/.bin/lerna publish --npm-tag=beta -m \"chore(@nestjs) publish %s release\"",
+    "publish:test":
+      "npm run prerelease && npm run build && ./node_modules/.bin/lerna publish --force-publish --npm-tag=test --skip-git -m \"chore(@nestjs) publish %s release\""
   },
   "engines": {
     "node": ">= 8.9.0"
@@ -132,9 +141,7 @@
     }
   },
   "nyc": {
-    "include": [
-      "packages/**/*.ts"
-    ],
+    "include": ["packages/**/*.ts"],
     "exclude": [
       "node_modules/",
       "packages/**/*.spec.ts",
@@ -154,23 +161,13 @@
       "packages/common/serializer/**/*",
       "packages/common/services/logger.service.ts"
     ],
-    "extension": [
-      ".ts"
-    ],
-    "require": [
-      "ts-node/register"
-    ],
-    "reporter": [
-      "text-summary",
-      "html"
-    ],
+    "extension": [".ts"],
+    "require": ["ts-node/register"],
+    "reporter": ["text-summary", "html"],
     "sourceMap": true,
     "instrument": true
   },
   "lint-staged": {
-    "packages/**/*.{ts,json}": [
-      "npm run format",
-      "git add"
-    ]
+    "packages/**/*.{ts,json}": ["npm run format", "git add"]
   }
 }

packages/core/test/helpers/application-ref-host.spec.ts

@@ -0,0 +1,12 @@
+import { expect } from 'chai';
+import { ApplicationReferenceHost } from './../../helpers/application-ref-host';
+
+describe('ApplicationReferenceHost', () => {
+  const applicationRefHost = new ApplicationReferenceHost();
+  it('should wrap application reference', () => {
+    const ref = {};
+    applicationRefHost.applicationRef = ref;
+
+    expect(applicationRefHost.applicationRef).to.be.eql(ref);
+  });
+});

packages/core/test/router/router-response-controller.spec.ts

@@ -1,16 +1,17 @@
-import * as sinon from 'sinon';
 import { expect } from 'chai';
-import { RouterResponseController } from '../../router/router-response-controller';
+import { of } from 'rxjs';
+import * as sinon from 'sinon';
 import { RequestMethod } from '../../../common';
-import { Observable, of } from 'rxjs';
 import { ExpressAdapter } from '../../adapters/express-adapter';
+import { RouterResponseController } from '../../router/router-response-controller';
 
 describe('RouterResponseController', () => {
+  let adapter: ExpressAdapter;
   let routerResponseController: RouterResponseController;
-  let handlerMock: sinon.SinonMock;
 
   beforeEach(() => {
-    routerResponseController = new RouterResponseController(new ExpressAdapter({}));
+    adapter = new ExpressAdapter({});
+    routerResponseController = new RouterResponseController(adapter);
   });
 
   describe('apply', () => {
@@ -67,9 +68,7 @@ describe('RouterResponseController', () => {
         it('should returns Promise', async () => {
           const value = 100;
           expect(
-            await routerResponseController.transformToResult(
-              of(value),
-            ),
+            await routerResponseController.transformToResult(of(value)),
           ).to.be.eq(100);
         });
       });
@@ -113,4 +112,22 @@ describe('RouterResponseController', () => {
       expect(response.render.calledWith(template, value)).to.be.true;
     });
   });
+
+  describe('setHeaders', () => {
+    let setHeaderStub: sinon.SinonStub;
+
+    beforeEach(() => {
+      setHeaderStub = sinon.stub(adapter, 'setHeader').callsFake(() => ({}));
+    });
+
+    it('should set all custom headers', () => {
+      const response = {};
+      const headers = [{ name: 'test', value: 'test_value' }];
+
+      routerResponseController.setHeaders(response, headers);
+      expect(
+        setHeaderStub.calledWith(response, headers[0].name, headers[0].value),
+      ).to.be.true;
+    });
+  });
 });

packages/core/test/router/routes-resolver.spec.ts

@@ -1,12 +1,11 @@
-import * as sinon from 'sinon';
+import { BadRequestException, Post } from '@nestjs/common';
 import { expect } from 'chai';
-import { RoutesResolver } from '../../router/routes-resolver';
+import * as sinon from 'sinon';
 import { Controller } from '../../../common/decorators/core/controller.decorator';
 import { Get } from '../../../common/decorators/http/request-mapping.decorator';
-import { RequestMethod } from '../../../common/enums/request-method.enum';
-import { ApplicationConfig } from '../../application-config';
-import { BadRequestException, Post } from '@nestjs/common';
 import { ExpressAdapter } from '../../adapters/express-adapter';
+import { ApplicationConfig } from '../../application-config';
+import { RoutesResolver } from '../../router/routes-resolver';
 
 describe('RoutesResolver', () => {
   @Controller('global')
@@ -22,14 +21,18 @@ describe('RoutesResolver', () => {
   let routesResolver: RoutesResolver;
   let container;
   let modules: Map<string, any>;
+  let applicationRef;
 
   before(() => {
     modules = new Map();
+    applicationRef = {
+      use: () => ({}),
+      setNotFoundHandler: sinon.spy(),
+      setErrorHandler: sinon.spy(),
+    };
     container = {
       getModules: () => modules,
-      getApplicationRef: () => ({
-        use: () => ({})
-      })
+      getApplicationRef: () => applicationRef,
     };
     router = {
       get() {},
@@ -38,10 +41,7 @@ describe('RoutesResolver', () => {
   });
 
   beforeEach(() => {
-    routesResolver = new RoutesResolver(
-      container,
-      new ApplicationConfig(),
-    );
+    routesResolver = new RoutesResolver(container, new ApplicationConfig());
   });
 
   describe('registerRouters', () => {
@@ -54,20 +54,27 @@ describe('RoutesResolver', () => {
       routes.set('TestRoute', routeWrapper);
 
       const appInstance = new ExpressAdapter(router);
-      const exploreSpy = sinon.spy((routesResolver as any).routerBuilder, 'explore');
+      const exploreSpy = sinon.spy(
+        (routesResolver as any).routerBuilder,
+        'explore',
+      );
       const moduleName = '';
 
-      sinon.stub((routesResolver as any).routerBuilder, 'extractRouterPath').callsFake(() => '');
+      sinon
+        .stub((routesResolver as any).routerBuilder, 'extractRouterPath')
+        .callsFake(() => '');
       routesResolver.registerRouters(routes, moduleName, '', appInstance);
 
       expect(exploreSpy.called).to.be.true;
-      expect(exploreSpy.calledWith(
-        routeWrapper.instance,
-        routeWrapper.metatype,
-        moduleName,
-        appInstance,
-        '',
-      )).to.be.true;
+      expect(
+        exploreSpy.calledWith(
+          routeWrapper.instance,
+          routeWrapper.metatype,
+          moduleName,
+          appInstance,
+          '',
+        ),
+      ).to.be.true;
     });
   });
 
@@ -110,4 +117,21 @@ describe('RoutesResolver', () => {
       });
     });
   });
+
+  describe('registerNotFoundHandler', () => {
+    it('should register not found handler', () => {
+      routesResolver.registerNotFoundHandler();
+
+      expect(applicationRef.setNotFoundHandler.called).to.be.true;
+    });
+  });
+
+  describe('registerExceptionHandler', () => {
+    it('should register exception handler', () => {
+      const ref = container.getApplicationRef();
+      routesResolver.registerExceptionHandler();
+
+      expect(applicationRef.setErrorHandler.called).to.be.true;
+    });
+  });
 });