Skip to content

Commit cf2d641

Browse files
author
kamil.mysliwiec
committed
Issue nestjs#39 naming refactor
1 parent f221bbe commit cf2d641

14 files changed

Lines changed: 46 additions & 45 deletions

src/core/injector/injector.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import 'reflect-metadata';
22
import { InstanceWrapper } from './container';
3-
import { UnkownDependenciesException } from '../../errors/exceptions/unkown-dependencies.exception';
3+
import { UnknownDependenciesException } from '../../errors/exceptions/unknown-dependencies.exception';
44
import { RuntimeException } from '../../errors/exceptions/runtime.exception';
55
import { Module } from './module';
66
import { Metatype } from '../../common/interfaces/metatype.interface';
@@ -122,7 +122,7 @@ export class Injector {
122122

123123
const instanceWrapper = this.scanForComponentInRelatedModules(module, name);
124124
if (isNil(instanceWrapper)) {
125-
throw new UnkownDependenciesException(metatype.name);
125+
throw new UnknownDependenciesException(metatype.name);
126126
}
127127
return instanceWrapper;
128128
}

src/core/injector/module.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { InstanceWrapper } from './container';
22
import { Injectable, Controller, NestModule } from '../../common/interfaces';
3-
import { UnkownExportException } from '../../errors/exceptions/unkown-export.exception';
3+
import { UnknownExportException } from '../../errors/exceptions/unknown-export.exception';
44
import { NestModuleMetatype } from '../../common/interfaces/module-metatype.interface';
55
import { Metatype } from '../../common/interfaces/metatype.interface';
66
import { ModuleRef } from './module-ref';
@@ -152,7 +152,7 @@ export class Module {
152152

153153
public addExportedComponent(exportedComponent: Metatype<Injectable>) {
154154
if (!this._components.get(exportedComponent.name)) {
155-
throw new UnkownExportException(exportedComponent.name);
155+
throw new UnknownExportException(exportedComponent.name);
156156
}
157157
this._exports.add(exportedComponent.name);
158158
}

src/core/middlewares/routes-mapper.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import 'reflect-metadata';
22
import { ExpressRouterExplorer } from '../router/router-explorer';
3-
import { UnkownRequestMappingException } from '../../errors/exceptions/unkown-request-mapping.exception';
3+
import { UnknownRequestMappingException } from '../../errors/exceptions/unknown-request-mapping.exception';
44
import { RequestMethod } from '../../common/enums/request-method.enum';
55
import { isUndefined, validatePath } from '../../common/utils/shared.utils';
66
import { PATH_METADATA } from '../../common/constants';
@@ -24,7 +24,7 @@ export class RoutesMapper {
2424
private mapObjectToRouteProps(route) {
2525
const { path, method } = route;
2626
if (isUndefined(path)) {
27-
throw new UnkownRequestMappingException();
27+
throw new UnknownRequestMappingException();
2828
}
2929
return {
3030
path: this.validateRoutePath(path),

src/core/router/router-explorer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import 'reflect-metadata';
22
import { Controller } from '../../common/interfaces/controller.interface';
33
import { RequestMethod } from '../../common/enums/request-method.enum';
44
import { RouterProxy, RouterProxyCallback } from './router-proxy';
5-
import { UnkownRequestMappingException } from '../../errors/exceptions/unkown-request-mapping.exception';
5+
import { UnknownRequestMappingException } from '../../errors/exceptions/unknown-request-mapping.exception';
66
import { ExpressAdapter } from '../adapters/express-adapter';
77
import { Metatype } from '../../common/interfaces/metatype.interface';
88
import { isUndefined, validatePath } from '../../common/utils/shared.utils';
@@ -90,7 +90,7 @@ export class ExpressRouterExplorer implements RouterExplorer {
9090

9191
private validateRoutePath(path: string): string {
9292
if (isUndefined(path)) {
93-
throw new UnkownRequestMappingException();
93+
throw new UnknownRequestMappingException();
9494
}
9595
return validatePath(path);
9696
}

src/core/test/injector/injector.spec.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { Injector } from '../../injector/injector';
55
import { Component } from '../../../common/utils/decorators/component.decorator';
66
import { RuntimeException } from '../../../errors/exceptions/runtime.exception';
77
import { Module } from '../../injector/module';
8-
import { UnkownDependenciesException } from '../../../errors/exceptions/unkown-dependencies.exception';
8+
import { UnknownDependenciesException } from '../../../errors/exceptions/unknown-dependencies.exception';
99

1010
describe('Injector', () => {
1111
let injector: Injector;
@@ -178,25 +178,25 @@ describe('Injector', () => {
178178
expect(scanForComponentInRelatedModules.called).to.be.true;
179179
});
180180

181-
it('should throw "UnkownDependenciesException" instanceWrapper is null', () => {
181+
it('should throw "UnknownDependenciesException" instanceWrapper is null', () => {
182182
scanForComponentInRelatedModules.returns(null);
183183
const collection = {
184184
has: () => false,
185185
};
186186

187187
expect(
188188
() => injector.scanForComponent(collection as any, metatype.name, null, metatype)
189-
).throws(UnkownDependenciesException);
189+
).throws(UnknownDependenciesException);
190190
});
191191

192-
it('should not throw "UnkownDependenciesException" instanceWrapper is not null', () => {
192+
it('should not throw "UnknownDependenciesException" instanceWrapper is not null', () => {
193193
scanForComponentInRelatedModules.returns({});
194194
const collection = {
195195
has: () => false,
196196
};
197197
expect(
198198
() => injector.scanForComponent(collection as any, metatype.name, null, metatype)
199-
).not.throws(UnkownDependenciesException);
199+
).not.throws(UnknownDependenciesException);
200200
});
201201

202202
});

src/core/test/injector/module.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { expect } from 'chai';
22
import * as sinon from 'sinon';
33
import { Module as ModuleDecorator } from '../../../common/utils/decorators/module.decorator';
4-
import { UnkownExportException } from '../../../errors/exceptions/unkown-export.exception';
4+
import { UnknownExportException } from '../../../errors/exceptions/unknown-export.exception';
55
import { Module } from '../../injector/module';
66
import { Component } from '../../../common/utils/decorators/component.decorator';
77
import { RuntimeException } from '../../../errors/exceptions/runtime.exception';
@@ -16,10 +16,10 @@ describe('Module', () => {
1616
module = new Module(TestModule);
1717
});
1818

19-
it('should throw "UnkownExportException" when given exported component is not a part of components array', () => {
19+
it('should throw "UnknownExportException" when given exported component is not a part of components array', () => {
2020
expect(
2121
() => module.addExportedComponent(TestComponent),
22-
).throws(UnkownExportException);
22+
).throws(UnknownExportException);
2323
});
2424

2525
it('should add route', () => {

src/core/test/middlewares/routes-mapper.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { RoutesMapper } from '../../middlewares/routes-mapper';
33
import { Controller } from '../../../common/utils/decorators/controller.decorator';
44
import { RequestMapping } from '../../../common/utils/decorators/request-mapping.decorator';
55
import { RequestMethod } from '../../../common/enums/request-method.enum';
6-
import { UnkownRequestMappingException } from '../../../errors/exceptions/unkown-request-mapping.exception';
6+
import { UnknownRequestMappingException } from '../../../errors/exceptions/unknown-request-mapping.exception';
77

88
describe('RoutesMapper', () => {
99
@Controller({ path: 'test' })
@@ -50,7 +50,7 @@ describe('RoutesMapper', () => {
5050

5151
expect(
5252
mapper.mapRouteToRouteProps.bind(mapper, config.forRoutes[0]),
53-
).throws(UnkownRequestMappingException);
53+
).throws(UnknownRequestMappingException);
5454
});
5555

5656
});
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
import { RuntimeException } from './runtime.exception';
2+
import { UnknownDependenciesMessage } from '../messages';
3+
4+
export class UnknownDependenciesException extends RuntimeException {
5+
constructor(type: string) {
6+
super(UnknownDependenciesMessage(type));
7+
}
8+
}
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
import { RuntimeException } from './runtime.exception';
2+
import { UnknownExportMessage } from '../messages';
3+
4+
export class UnknownExportException extends RuntimeException {
5+
constructor(name: string) {
6+
super(UnknownExportMessage(name));
7+
}
8+
}
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
import { RuntimeException } from './runtime.exception';
2+
import { UNKNOWN_REQUEST_MAPPING } from '../messages';
3+
4+
export class UnknownRequestMappingException extends RuntimeException {
5+
constructor() {
6+
super(UNKNOWN_REQUEST_MAPPING);
7+
}
8+
}

0 commit comments

Comments
 (0)