bugfix(@nestjs/core) nest seems to fails silently nestjs#287

Author: kamilmysliwiec

CHANGELOG.md

@@ -1,5 +1,9 @@
 ## 4.6.0
-- **core** add ability to inject application reference (`APP_REF` token)
+- **core**: [feature] add ability to inject `express` reference (`EXPRESS_REF` token)
+- **core**: [feature] `NestFactory.create()` now accepts third argument `HttpsOptions`
+- **core**: [bugfix] Nest seems to fails silently #287
+- **core**: [bugfix] WebSocket Gateway - Secure websockets (`wss://`) #384
+- **core**: [bugfix] can't select/get from context when using `NestFactory.createMicroservice()`  #398
 - **core**: [bugfix] interceptor `$stream` observable returns another observable instead of the response object #376 
 - **core**: [bugfix] `Observable.throw` from controller results in unhandled rejection promise #373
 

src/common/interfaces/https-options.interface.ts

@@ -0,0 +1,14 @@
+export interface HttpsOptions {
+  pfx?: any;
+  key?: any;
+  passphrase?: string;
+  cert?: any;
+  ca?: any;
+  crl?: any;
+  ciphers?: string;
+  honorCipherOrder?: boolean;
+  requestCert?: boolean;
+  rejectUnauthorized?: boolean;
+  NPNProtocols?: any;
+  SNICallback?: (servername: string, cb: (err: Error, ctx: any) => any) => any;
+}

src/common/interfaces/nest-microservice.interface.ts

@@ -3,8 +3,9 @@ import { ExceptionFilter } from './exceptions/exception-filter.interface';
 import { PipeTransform } from './pipe-transform.interface';
 import { NestInterceptor } from './nest-interceptor.interface';
 import { CanActivate } from './can-activate.interface';
+import { INestApplicationContext } from './nest-application-context.interface';
 
-export interface INestMicroservice {
+export interface INestMicroservice extends INestApplicationContext {
   /**
    * Starts the microservice.
    *

src/core/injector/injector.ts

@@ -307,10 +307,10 @@ export class Injector {
       }
       return component;
     } catch (e) {
-      if (e instanceof UndefinedDependencyException) {
-        throw e;
+      if (e instanceof RuntimeException) {
+        return null;
       }
-      return null;
+      throw e;
     }
   }
 

src/core/injector/module.ts

@@ -19,7 +19,7 @@ import { InterceptorsConsumer } from './../interceptors/interceptors-consumer';
 import { GuardsConsumer } from './../guards/guards-consumer';
 import { ModulesContainer } from './modules-container';
 import { Reflector } from '../services/reflector.service'; 
-import { APP_REF } from './tokens';
+import { EXPRESS_REF } from './tokens';
 
 export interface CustomComponent {
   provide: any;
@@ -127,8 +127,8 @@ export class Module {
   } 
 
   public addApplicationRef(applicationRef: any) { 
-    this._components.set(APP_REF, { 
-      name: APP_REF, 
+    this._components.set(EXPRESS_REF, { 
+      name: EXPRESS_REF, 
       metatype: applicationRef, 
       isResolved: true, 
       instance: applicationRef, 

src/core/injector/tokens.ts

@@ -1 +1 @@
-export const APP_REF = 'APP_REF';
+export const EXPRESS_REF = 'EXPRESS_REF';

src/core/nest-application.ts

@@ -1,4 +1,5 @@
 import * as http from 'http';
+import * as https from 'https';
 import * as optional from 'optional';
 import * as bodyParser from 'body-parser';
 import iterate from 'iterare';
@@ -33,6 +34,7 @@ import { RoutesResolver } from './router/routes-resolver';
 import { MicroservicesPackageNotFoundException } from './errors/exceptions/microservices-package-not-found.exception';
 import { MiddlewaresContainer } from './middlewares/container';
 import { NestApplicationContext } from './nest-application-context';
+import { HttpsOptions } from '@nestjs/common/interfaces/https-options.interface';
 
 const { SocketModule } =
   optional('@nestjs/websockets/socket-module') || ({} as any);
@@ -59,12 +61,15 @@ export class NestApplication extends NestApplicationContext
   private readonly microservices = [];
   private isInitialized = false;
 
-  constructor(container: NestContainer, private readonly express) {
+  constructor(
+    container: NestContainer,
+    private readonly express,
+    private readonly httpsOptions: HttpsOptions = null,
+  ) {
     super(container, [], null);
 
-    const modules = this.container.getModules().values();
-    this.contextModule = modules.next().value;
-    this.httpServer = http.createServer(express);
+    this.selectContextModule();
+    this.httpServer = this.createServer();
 
     const ioAdapter = IoAdapter ? new IoAdapter(this.httpServer) : null;
     this.config = new ApplicationConfig(ioAdapter);
@@ -75,6 +80,18 @@ export class NestApplication extends NestApplicationContext
     );
   }
 
+  public selectContextModule() {
+    const modules = this.container.getModules().values();
+    this.contextModule = modules.next().value;
+  }
+
+  public createServer(): any {
+    if (!this.httpsOptions) {
+      return http.createServer(this.express);
+    }
+    return https.createServer(this.httpsOptions, this.express);
+  }
+
   public async setupModules() {
     this.socketModule && this.socketModule.setup(this.container, this.config);
 
@@ -173,7 +190,11 @@ export class NestApplication extends NestApplicationContext
   }
 
   public async listen(port: number | string, callback?: () => void);
-  public async listen(port: number | string, hostname: string, callback?: () => void);
+  public async listen(
+    port: number | string,
+    hostname: string,
+    callback?: () => void,
+  );
   public async listen(port: number | string, ...args) {
     !this.isInitialized && (await this.init());
 

src/core/nest-factory.ts

@@ -18,6 +18,7 @@ import {
 import { MetadataScanner } from './metadata-scanner';
 import { MicroservicesPackageNotFoundException } from './errors/exceptions/microservices-package-not-found.exception';
 import { NestApplicationContext } from './nest-application-context';
+import { HttpsOptions } from '@nestjs/common/interfaces/https-options.interface';
 
 const { NestMicroservice } =
   optional('@nestjs/microservices/nest-microservice') || ({} as any);
@@ -41,10 +42,11 @@ export class NestFactoryStatic {
   public async create(
     module,
     express = ExpressAdapter.create(),
+    httpsOptions: HttpsOptions = null, 
   ): Promise<INestApplication> {
     await this.initialize(module, express);
     return this.createNestInstance<NestApplication>(
-      new NestApplication(this.container, express),
+      new NestApplication(this.container, express, httpsOptions),
     );
   }
 

src/microservices/nest-microservice.ts

@@ -22,13 +22,15 @@ import { CustomTransportStrategy } from '@nestjs/microservices';
 import { Module } from '@nestjs/core/injector/module';
 import { isNil, isUndefined } from '@nestjs/common/utils/shared.utils';
 import { OnModuleDestroy } from '@nestjs/common/interfaces';
+import { NestApplicationContext } from '@nestjs/core/nest-application-context';
 
 const { SocketModule } =
   optional('@nestjs/websockets/socket-module') || ({} as any);
 const { IoAdapter } =
   optional('@nestjs/websockets/adapters/io-adapter') || ({} as any);
 
-export class NestMicroservice implements INestMicroservice {
+export class NestMicroservice extends NestApplicationContext
+  implements INestMicroservice {
   private readonly logger = new Logger(NestMicroservice.name, true);
   private readonly microservicesModule = new MicroservicesModule();
   private readonly socketModule = SocketModule ? new SocketModule() : null;
@@ -41,9 +43,11 @@ export class NestMicroservice implements INestMicroservice {
   private isInitHookCalled = false;
 
   constructor(
-    private readonly container: NestContainer,
+    container: NestContainer,
     config: MicroserviceConfiguration = {},
   ) {
+    super(container, [], null);
+  
     const ioAdapter = IoAdapter ? new IoAdapter() : null;
     this.config = new ApplicationConfig(ioAdapter);