performance(nestjs) context creator improvements

Author: kamilmysliwiec

packages/core/router/router-execution-context.ts

@@ -199,7 +199,7 @@ export class RouterExecutionContext {
     guards: any[],
     instance: Controller,
     callback: (...args) => any,
-  ) {
+  ): Function | null {
     const canActivateFn = async (args: any[]) => {
       const canActivate = await this.guardsConsumer.tryActivate(
         guards,

packages/microservices/context/rpc-context-creator.ts

@@ -42,6 +42,7 @@ export class RpcContextCreator {
       callback,
       module,
     );
+    const fnCanActivate = this.createGuardsFn(guards, instance, callback);
     const handler = (args: any[]) => async () => {
       const [data, ...params] = args;
       const result = await this.pipesConsumer.applyPipes(
@@ -53,15 +54,8 @@ export class RpcContextCreator {
     };
 
     return this.rpcProxy.create(async (...args) => {
-      const canActivate = await this.guardsConsumer.tryActivate(
-        guards,
-        args,
-        instance,
-        callback,
-      );
-      if (!canActivate) {
-        throw new RpcException(FORBIDDEN_MESSAGE);
-      }
+      fnCanActivate && (await fnCanActivate(args));
+
       return await this.interceptorsConsumer.intercept(
         interceptors,
         args,
@@ -83,4 +77,23 @@ export class RpcContextCreator {
     const paramtypes = this.reflectCallbackParamtypes(instance, callback);
     return paramtypes && paramtypes.length ? paramtypes[0] : null;
   }
+
+  public createGuardsFn(
+    guards: any[],
+    instance: Controller,
+    callback: (...args) => any,
+  ): Function | null {
+    const canActivateFn = async (args: any[]) => {
+      const canActivate = await this.guardsConsumer.tryActivate(
+        guards,
+        args,
+        instance,
+        callback,
+      );
+      if (!canActivate) {
+        throw new RpcException(FORBIDDEN_MESSAGE);
+      }
+    };
+    return guards.length ? canActivateFn : null;
+  }
 }

packages/microservices/context/rpc-proxy.ts

@@ -1,17 +1,17 @@
+import { ExecutionContextHost } from '@nestjs/core/helpers/execution-context.host';
 import { Observable } from 'rxjs';
 import { RpcExceptionsHandler } from '../exceptions/rpc-exceptions-handler';
-import { ExecutionContextHost } from '@nestjs/core/helpers/execution-context.host';
 
 export class RpcProxy {
   public create(
     targetCallback: (...args) => Promise<Observable<any>>,
     exceptionsHandler: RpcExceptionsHandler,
   ): (...args) => Promise<Observable<any>> {
     return async (...args) => {
-      const host = new ExecutionContextHost(args);
       try {
         return await targetCallback(...args);
       } catch (e) {
+        const host = new ExecutionContextHost(args);
         return exceptionsHandler.handle(e, host);
       }
     };

packages/websockets/context/ws-context-creator.ts

@@ -1,17 +1,15 @@
-import { Observable } from 'rxjs';
-import { WsProxy } from './ws-proxy';
-import { WsExceptionsHandler } from '../exceptions/ws-exceptions-handler';
-import { ExceptionFiltersContext } from './exception-filters-context';
-import { Controller } from '@nestjs/common/interfaces';
-import { PipesContextCreator } from '@nestjs/core/pipes/pipes-context-creator';
-import { PipesConsumer } from '@nestjs/core/pipes/pipes-consumer';
 import { PARAMTYPES_METADATA } from '@nestjs/common/constants';
-import { GuardsContextCreator } from '@nestjs/core/guards/guards-context-creator';
-import { GuardsConsumer } from '@nestjs/core/guards/guards-consumer';
+import { Controller } from '@nestjs/common/interfaces';
 import { FORBIDDEN_MESSAGE } from '@nestjs/core/guards/constants';
-import { WsException } from '../exceptions/ws-exception';
+import { GuardsConsumer } from '@nestjs/core/guards/guards-consumer';
+import { GuardsContextCreator } from '@nestjs/core/guards/guards-context-creator';
 import { InterceptorsConsumer } from '@nestjs/core/interceptors/interceptors-consumer';
 import { InterceptorsContextCreator } from '@nestjs/core/interceptors/interceptors-context-creator';
+import { PipesConsumer } from '@nestjs/core/pipes/pipes-consumer';
+import { PipesContextCreator } from '@nestjs/core/pipes/pipes-context-creator';
+import { WsException } from '../exceptions/ws-exception';
+import { ExceptionFiltersContext } from './exception-filters-context';
+import { WsProxy } from './ws-proxy';
 
 export class WsContextCreator {
   constructor(
@@ -43,6 +41,7 @@ export class WsContextCreator {
       callback,
       module,
     );
+    const fnCanActivate = this.createGuardsFn(guards, instance, callback);
     const handler = (args: any[]) => async () => {
       const [client, data, ...params] = args;
       const result = await this.pipesConsumer.applyPipes(
@@ -54,15 +53,8 @@ export class WsContextCreator {
     };
 
     return this.wsProxy.create(async (...args) => {
-      const canActivate = await this.guardsConsumer.tryActivate(
-        guards,
-        args,
-        instance,
-        callback,
-      );
-      if (!canActivate) {
-        throw new WsException(FORBIDDEN_MESSAGE);
-      }
+      fnCanActivate && (await fnCanActivate(args));
+
       return await this.interceptorsConsumer.intercept(
         interceptors,
         args,
@@ -84,4 +76,23 @@ export class WsContextCreator {
     const paramtypes = this.reflectCallbackParamtypes(instance, callback);
     return paramtypes && paramtypes.length ? paramtypes[1] : null;
   }
+
+  public createGuardsFn(
+    guards: any[],
+    instance: Controller,
+    callback: (...args) => any,
+  ): Function | null {
+    const canActivateFn = async (args: any[]) => {
+      const canActivate = await this.guardsConsumer.tryActivate(
+        guards,
+        args,
+        instance,
+        callback,
+      );
+      if (!canActivate) {
+        throw new WsException(FORBIDDEN_MESSAGE);
+      }
+    };
+    return guards.length ? canActivateFn : null;
+  }
 }

packages/websockets/context/ws-proxy.ts

@@ -1,16 +1,16 @@
-import { WsExceptionsHandler } from './../exceptions/ws-exceptions-handler';
 import { ExecutionContextHost } from '@nestjs/core/helpers/execution-context.host';
+import { WsExceptionsHandler } from './../exceptions/ws-exceptions-handler';
 
 export class WsProxy {
   public create(
     targetCallback: (...args) => Promise<void>,
     exceptionsHandler: WsExceptionsHandler,
   ): (...args) => Promise<void> {
     return async (...args) => {
-      const host = new ExecutionContextHost(args);
       try {
         return await targetCallback(...args);
       } catch (e) {
+        const host = new ExecutionContextHost(args);
         exceptionsHandler.handle(e, host);
       }
     };