Skip to content

Commit e39c9d9

Browse files
bugfix(@nestjs/core) add circular dependency (related modules) check
1 parent b84c2b0 commit e39c9d9

2 files changed

Lines changed: 1076 additions & 165 deletions

File tree

packages/core/injector/module.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -287,13 +287,14 @@ export class Module {
287287
if (this._components.has(token)) {
288288
return token;
289289
}
290-
const relatedModules = [...this._relatedModules.values()];
291-
const modulesTokens = relatedModules
290+
const importedArray = [...this._relatedModules.values()];
291+
const importedRefNames = importedArray
292+
.filter(item => item)
292293
.map(({ metatype }) => metatype)
293294
.filter(metatype => metatype)
294295
.map(({ name }) => name);
295296

296-
if (modulesTokens.indexOf(token) < 0) {
297+
if (importedRefNames.indexOf(token) < 0) {
297298
const { name } = this.metatype;
298299
throw new UnknownExportException(name);
299300
}

0 commit comments

Comments
 (0)