Merge pull request nestjs#1970 from rokerkony/bug/fix-bc-on-http-exception

bugfix(common): fix breaking change on http exception

Author: kamilmysliwiec

packages/common/exceptions/http.exception.ts

@@ -1,5 +1,3 @@
-import { isObject } from '../utils/shared.utils';
-
 export class HttpException extends Error {
   public readonly message: any;
 
@@ -22,9 +20,7 @@ export class HttpException extends Error {
     private readonly status: number,
   ) {
     super();
-    this.message =
-      (isObject(response) && (response as { message?: string }).message) ||
-      response;
+    this.message = response;
   }
 
   public getResponse(): string | object {

packages/common/test/exceptions/http.exception.spec.ts

@@ -0,0 +1,47 @@
+import { expect } from 'chai';
+import { BadRequestException, HttpException, NotFoundException } from '../../exceptions';
+
+describe('HttpException', () => {
+  it('should return a message as a string when input is a string', () => {
+    const message: string = 'My error message';
+    expect(new HttpException(message, 404).message).to.be.eql('My error message');
+  });
+
+  it('should return a message as an object when input is an object', () => {
+    const message: object = {
+      msg: 'My error message',
+      reason: 'this can be a human readable reason',
+      anything: 'else',
+    };
+    expect(new HttpException(message, 404).message).to.be.eql(message);
+  });
+
+  it('should return a message from a built-in exception as an object', () => {
+    const message: string = 'My error message';
+    expect(new BadRequestException(message).message).to.be.eql({
+      statusCode: 400,
+      error: 'Bad Request',
+      message: 'My error message',
+    });
+  });
+
+  it('should return an object even when the message is undefined', () => {
+    expect(new BadRequestException().message).to.be.eql({statusCode: 400, error: 'Bad Request'});
+  });
+
+  it('should return a status code', () => {
+    expect(new BadRequestException().getStatus()).to.be.eql(400);
+    expect(new NotFoundException().getStatus()).to.be.eql(404);
+  });
+
+  it('should return a response', () => {
+    expect(new BadRequestException().getResponse()).to.be.eql({
+      error: 'Bad Request',
+      statusCode: 400,
+    });
+    expect(new NotFoundException().getResponse()).to.be.eql({
+      error: 'Not Found',
+      statusCode: 404,
+    });
+  });
+});