Merge pull request nestjs#3592 from tonyhallett/external-context-creator-expect-in-catch

test(core): fix expectation in catch

Author: kamilmysliwiec

packages/core/test/helpers/external-context-creator.spec.ts

@@ -22,6 +22,7 @@ describe('ExternalContextCreator', () => {
   let applySpy: sinon.SinonSpy;
   let guardsConsumer: GuardsConsumer;
   let pipesConsumer: PipesConsumer;
+  let guardsContextCreator: GuardsContextCreator;
 
   beforeEach(() => {
     callback = {
@@ -33,8 +34,10 @@ describe('ExternalContextCreator', () => {
 
     guardsConsumer = new GuardsConsumer();
     pipesConsumer = new PipesConsumer();
+    guardsContextCreator = new GuardsContextCreator(new NestContainer());
+    sinon.stub(guardsContextCreator, 'create').returns([{}] as any);
     contextCreator = new ExternalContextCreator(
-      new GuardsContextCreator(new NestContainer()),
+      guardsContextCreator,
       guardsConsumer,
       new InterceptorsContextCreator(new NestContainer()),
       new InterceptorsConsumer(),
@@ -73,11 +76,17 @@ describe('ExternalContextCreator', () => {
       });
       describe('when proxy function called', () => {
         describe('when can not activate', () => {
-          it('should throw exception when "tryActivate" returns false', () => {
+          it('should throw exception when "tryActivate" returns false', async () => {
             sinon
               .stub(guardsConsumer, 'tryActivate')
               .callsFake(async () => false);
-            proxyContext(1, 2, 3).catch(err => expect(err).to.not.be.undefined);
+            let err: any;
+            try {
+              await proxyContext(1, 2, 3);
+            } catch (e) {
+              err = e;
+            }
+            expect(err).to.be.undefined;
           });
         });
         describe('when can activate', () => {