Skip to content

Commit 9a75e92

Browse files
committed
update readme, bug fix kubernetes detection
1 parent 8e283f3 commit 9a75e92

5 files changed

Lines changed: 27 additions & 61 deletions

File tree

OpenFlow/src/Messages/Message.ts

Lines changed: 21 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -1205,17 +1205,26 @@ export class Message {
12051205
Logger.otel.endSpan(span);
12061206
return name;
12071207
}
1208-
private async EnsureNoderedInstance(cli: WebSocketServerClient, parent: Span): Promise<void> {
1208+
private async DetectDocker() {
12091209
if (Message.detectdocker) {
1210-
try {
1211-
const docker = new Docker();
1212-
Message.usedocker = true;
1213-
} catch (error) {
1214-
console.log(error);
1215-
Message.usedocker = false;
1210+
if (!NoderedUtil.isKubernetes() && NoderedUtil.isDocker()) {
1211+
if (NoderedUtil.IsNullEmpty(process.env["KUBERNETES_SERVICE_HOST"])) {
1212+
try {
1213+
const docker = new Docker();
1214+
var list = await docker.listContainers();
1215+
Message.usedocker = true;
1216+
} catch (error) {
1217+
console.log(error);
1218+
Message.usedocker = false;
1219+
}
1220+
1221+
}
12161222
}
12171223
Message.detectdocker = false;
12181224
}
1225+
}
1226+
private async EnsureNoderedInstance(cli: WebSocketServerClient, parent: Span): Promise<void> {
1227+
await this.DetectDocker();
12191228
if (Message.usedocker) {
12201229
this.DockerEnsureNoderedInstance(cli, parent);
12211230
} else {
@@ -1872,16 +1881,7 @@ export class Message {
18721881
Logger.otel.endSpan(span);
18731882
}
18741883
private async DeleteNoderedInstance(cli: WebSocketServerClient, parent: Span): Promise<void> {
1875-
if (Message.detectdocker) {
1876-
try {
1877-
const docker = new Docker();
1878-
Message.usedocker = true;
1879-
} catch (error) {
1880-
console.log(error);
1881-
Message.usedocker = false;
1882-
}
1883-
Message.detectdocker = false;
1884-
}
1884+
await this.DetectDocker();
18851885
if (Message.usedocker) {
18861886
this.dockerDeleteNoderedInstance(cli, parent);
18871887
} else {
@@ -1923,16 +1923,7 @@ export class Message {
19231923
this.Send(cli);
19241924
}
19251925
private async DeleteNoderedPod(cli: WebSocketServerClient, parent: Span): Promise<void> {
1926-
if (Message.detectdocker) {
1927-
try {
1928-
const docker = new Docker();
1929-
Message.usedocker = true;
1930-
} catch (error) {
1931-
console.log(error);
1932-
Message.usedocker = false;
1933-
}
1934-
Message.detectdocker = false;
1935-
}
1926+
await this.DetectDocker();
19361927
if (Message.usedocker) {
19371928
this.dockerDeleteNoderedPod(cli, parent);
19381929
} else {
@@ -2036,16 +2027,7 @@ export class Message {
20362027
this.Send(cli);
20372028
}
20382029
private async RestartNoderedInstance(cli: WebSocketServerClient, parent: Span): Promise<void> {
2039-
if (Message.detectdocker) {
2040-
try {
2041-
const docker = new Docker();
2042-
Message.usedocker = true;
2043-
} catch (error) {
2044-
console.log(error);
2045-
Message.usedocker = false;
2046-
}
2047-
Message.detectdocker = false;
2048-
}
2030+
await this.DetectDocker();
20492031
if (Message.usedocker) {
20502032
this.DockerRestartNoderedInstance(cli, parent);
20512033
} else {
@@ -2179,16 +2161,7 @@ export class Message {
21792161
private static detectdocker: boolean = true;
21802162
private static usedocker: boolean = false;
21812163
private async GetNoderedInstance(cli: WebSocketServerClient, parent: Span): Promise<void> {
2182-
if (Message.detectdocker) {
2183-
try {
2184-
const docker = new Docker();
2185-
Message.usedocker = true;
2186-
} catch (error) {
2187-
console.log(error);
2188-
Message.usedocker = false;
2189-
}
2190-
Message.detectdocker = false;
2191-
}
2164+
await this.DetectDocker();
21922165
if (Message.usedocker) {
21932166
this.dockerGetNoderedInstance(cli, parent);
21942167
} else {
@@ -2334,16 +2307,7 @@ export class Message {
23342307
this.Send(cli);
23352308
}
23362309
private async GetNoderedInstanceLog(cli: WebSocketServerClient, parent: Span): Promise<void> {
2337-
if (Message.detectdocker) {
2338-
try {
2339-
const docker = new Docker();
2340-
Message.usedocker = true;
2341-
} catch (error) {
2342-
console.log(error);
2343-
Message.usedocker = false;
2344-
}
2345-
Message.detectdocker = false;
2346-
}
2310+
await this.DetectDocker();
23472311
if (Message.usedocker) {
23482312
this.DockerGetNoderedInstanceLog(cli, parent);
23492313
} else {

OpenFlowNodeRED/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@openiap/nodered",
3-
"version": "1.2.100",
3+
"version": "1.2.102",
44
"description": "Simple wrapper around NodeRed, RabbitMQ and MongoDB to support a more scaleable NodeRed implementation.\r Also the \"backend\" for [OpenRPA](https://github.com/skadefro/OpenRPA)",
55
"main": "index.js",
66
"scripts": {

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.2.101
1+
1.2.102

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@openiap/openflow",
3-
"version": "1.2.100",
3+
"version": "1.2.102",
44
"description": "Simple wrapper around NodeRed, RabbitMQ and MongoDB to support a more scaleable NodeRed implementation.\r Also the \"backend\" for [OpenRPA](https://github.com/skadefro/OpenRPA)",
55
"main": "index.js",
66
"scripts": {
@@ -30,7 +30,7 @@
3030
},
3131
"dependencies": {
3232
"@kubernetes/client-node": "0.14.1",
33-
"@openiap/openflow-api": "^1.0.63",
33+
"@openiap/openflow-api": "^1.0.64",
3434
"@opentelemetry/api": "^0.18.1",
3535
"@opentelemetry/core": "^0.18.2",
3636
"@opentelemetry/exporter-collector-grpc": "^0.18.2",

readme.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
Simple wrapper around NodeRed, RabbitMQ and MongoDB to support a more scalable NodeRed implementation.
33
Also the "backend" for [OpenRPA](https://github.com/open-rpa/OpenRPA)
44

5+
Test it in a single user installation [here](https://app.openiap.io/)
6+
57
Join rocket chat [#openrpa](https://rocket.openiap.io/)
68
or check out the [community forum](https://nn.openiap.io/)
79

0 commit comments

Comments
 (0)