add NO_PROXY

Author: skadefro

OpenFlow/src/Config.ts

@@ -46,7 +46,7 @@ export class Config {
         Config.NODE_ENV = Config.getEnv("NODE_ENV", "development");
         Config.HTTP_PROXY = Config.getEnv("HTTP_PROXY", "");
         Config.HTTPS_PROXY = Config.getEnv("HTTPS_PROXY", "");
-
+        Config.NO_PROXY = Config.getEnv("NO_PROXY", "");
 
         Config.stripe_api_key = Config.getEnv("stripe_api_key", "");
         Config.stripe_api_secret = Config.getEnv("stripe_api_secret", "");
@@ -206,6 +206,7 @@ export class Config {
     public static NODE_ENV: string = Config.getEnv("NODE_ENV", "development");
     public static HTTP_PROXY: string = Config.getEnv("HTTP_PROXY", "");
     public static HTTPS_PROXY: string = Config.getEnv("HTTPS_PROXY", "");
+    public static NO_PROXY: string = Config.getEnv("NO_PROXY", "");
 
     public static stripe_api_key: string = Config.getEnv("stripe_api_key", "");
     public static stripe_api_secret: string = Config.getEnv("stripe_api_secret", "");

OpenFlowNodeRED/src/Config.ts

@@ -25,6 +25,7 @@ export class Config {
         Config.NODE_ENV = Config.getEnv("NODE_ENV", "development");
         Config.HTTP_PROXY = Config.getEnv("HTTP_PROXY", "");
         Config.HTTPS_PROXY = Config.getEnv("HTTPS_PROXY", "");
+        Config.NO_PROXY = Config.getEnv("NO_PROXY", "");
 
         Config.saml_federation_metadata = Config.getEnv("saml_federation_metadata", "");
         Config.saml_issuer = Config.getEnv("saml_issuer", "");
@@ -93,6 +94,7 @@ export class Config {
     public static NODE_ENV: string = Config.getEnv("NODE_ENV", "development");
     public static HTTP_PROXY: string = Config.getEnv("HTTP_PROXY", "");
     public static HTTPS_PROXY: string = Config.getEnv("HTTPS_PROXY", "");
+    public static NO_PROXY: string = Config.getEnv("NO_PROXY", "");
 
     public static allow_start_from_cache: boolean = Config.parseBoolean(Config.getEnv("allow_start_from_cache", "false"));
     public static auto_restart_when_needed: boolean = Config.parseBoolean(Config.getEnv("auto_restart_when_needed", "true"));

OpenFlowNodeRED/src/node-red-contrib-openflow-storage.ts

@@ -582,8 +582,13 @@ export class noderedcontribopenflowstorage {
                 //     npmrc.content = fs.readFileSync(npmrcFile, "utf8");
                 //     await this._setnpmrc(npmrc);
             } else if (!NoderedUtil.IsNullEmpty(Config.HTTP_PROXY) || !NoderedUtil.IsNullEmpty(Config.HTTPS_PROXY)) {
+                // According to https://docs.npmjs.com/cli/v7/using-npm/config it should be picked up by envoriment variables, 
+                // HTTP_PROXY, HTTPS_PROXY and NO_PROXY 
                 const npmrc = new noderednpmrc();
                 npmrc.content = "proxy=" + Config.HTTP_PROXY + "\n" + "https-proxy=" + Config.HTTPS_PROXY;
+                if (!NoderedUtil.IsNullEmpty(Config.NO_PROXY)) {
+                    npmrc.content += "\n" + "noproxy=" + Config.NO_PROXY;
+                }
                 npmrc.content += "\n" + "registry=http://registry.npmjs.org/";
                 fs.writeFileSync(npmrcFile, npmrc.content);
             } else {

docker-compose-traefik.yml

@@ -62,9 +62,10 @@ services:
       - protocol=http
       - port=3000
       - domain=localhost.openiap.io
-      # Fill to set proxy settings inside docker instances, you may also need to add an npmrc entry to the nodered collection !
+
       - HTTP_PROXY=
       - HTTPS_PROXY=
+      - NO_PROXY=
 
       - enable_openflow_amqp=false # enable this to use the openflow amqp, only usefull when you have more than one replicas
       - amqp_prefetch=25