Deserializing null avoids Py_None()

Author: ijl

src/decode.rs

@@ -8,6 +8,7 @@ use smallvec::SmallVec;
 use std::borrow::Cow;
 use std::fmt;
 use std::marker::PhantomData;
+use crate::typeref;
 
 import_exception!(json, JSONDecodeError);
 
@@ -57,7 +58,7 @@ impl<'de, 'a> Visitor<'de> for JsonValue<'a> {
     }
 
     fn visit_unit<E>(self) -> Result<Self::Value, E> {
-        Ok(unsafe { pyo3::ffi::Py_None() })
+        Ok(unsafe { typeref::NONE })
     }
 
     fn visit_bool<E>(self, value: bool) -> Result<Self::Value, E>

src/typeref.rs

@@ -4,6 +4,7 @@ use pyo3::prelude::*;
 use pyo3::types::*;
 use std::sync::Once;
 
+pub static mut NONE: *mut pyo3::ffi::PyObject = 0 as *mut pyo3::ffi::PyObject;
 pub static mut STR_PTR: *mut pyo3::ffi::PyTypeObject = 0 as *mut pyo3::ffi::PyTypeObject;
 pub static mut BYTES_PTR: *mut pyo3::ffi::PyTypeObject = 0 as *mut pyo3::ffi::PyTypeObject;
 pub static mut DICT_PTR: *mut pyo3::ffi::PyTypeObject = 0 as *mut pyo3::ffi::PyTypeObject;
@@ -18,6 +19,7 @@ static INIT: Once = Once::new();
 
 pub fn init_typerefs(py: Python) {
     INIT.call_once(|| unsafe {
+        NONE = pyo3::ffi::Py_None();
         STR_PTR = PyUnicode::new(py, "python").as_ref(py).get_type_ptr();
         BYTES_PTR = PyBytes::new(py, b"python").as_ref(py).get_type_ptr();
         DICT_PTR = PyDict::new(py).as_ref().get_type_ptr();

test/test_type.py

@@ -31,15 +31,24 @@ def test_bool(self):
             self.assertEqual(orjson.dumps(obj), ref.encode('utf-8'))
             self.assertEqual(orjson.loads(ref), obj)
 
-    def test_bool_array(self):
+    def test_bool_true_array(self):
         """
-        bool array
+        bool true array
         """
         obj = [True] * 256
         ref = ('[' + ('true,' * 255) + 'true]').encode('utf-8')
         self.assertEqual(orjson.dumps(obj), ref)
         self.assertEqual(orjson.loads(ref), obj)
 
+    def test_bool_false_array(self):
+        """
+        bool false array
+        """
+        obj = [False] * 256
+        ref = ('[' + ('false,' * 255) + 'false]').encode('utf-8')
+        self.assertEqual(orjson.dumps(obj), ref)
+        self.assertEqual(orjson.loads(ref), obj)
+
     def test_none(self):
         """
         null