Dict key must be str

Author: ijl

src/encode.rs

@@ -82,12 +82,15 @@ impl<'p, 'a> Serialize for SerializePyObject<'p, 'a> {
             if len != 0 {
                 let mut map = serializer.serialize_map(Some(len))?;
                 for (key, value) in val.iter() {
+                    if key.get_type_ptr() != self.refs.str {
+                        return Err(ser::Error::custom(format_args!(
+                            "Dict key must be str, not: {:?}",
+                            key
+                        )));
+                    }
+                    let keystr: &PyUnicode = key.extract().unwrap();
                     map.serialize_entry(
-                        &SerializePyObject {
-                            py: self.py,
-                            refs: self.refs,
-                            obj: key,
-                        },
+                        unsafe { std::str::from_utf8_unchecked(keystr.as_bytes()) },
                         &SerializePyObject {
                             py: self.py,
                             refs: self.refs,

test/test_type.py

@@ -124,3 +124,12 @@ def test_dict_large(self):
         obj = {'key_%s' % idx: 'value' for idx in range(513)}
         self.assertEqual(len(obj), 513)
         self.assertEqual(orjson.loads(orjson.dumps(obj)), obj)
+
+    def test_dict_invalid_key(self):
+        """
+        dict invalid key
+        """
+        with self.assertRaises(TypeError):
+            orjson.dumps({1: 'value'})
+        with self.assertRaises(TypeError):
+            orjson.dumps({b'key': 'value'})