Skip to content

Commit f9c1fa2

Browse files
hauntsaninjaijl
authored andcommitted
orjson.dumps: fix inspect.signature
1 parent 23dc0f2 commit f9c1fa2

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ use std::borrow::Cow;
2020
use std::os::raw::c_char;
2121
use std::ptr::NonNull;
2222

23-
const DUMPS_DOC: &str = "dumps(obj, /, default, option)\n--\n\nSerialize Python objects to JSON.\0";
23+
const DUMPS_DOC: &str = "dumps(obj, /, default=None, option=None)\n--\n\nSerialize Python objects to JSON.\0";
2424
const LOADS_DOC: &str = "loads(obj, /)\n--\n\nDeserialize JSON to Python objects.\0";
2525

2626
macro_rules! opt {

test/test_api.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,14 +166,17 @@ def test_dumps_signature(self):
166166
dumps() valid __text_signature__
167167
"""
168168
self.assertEqual(
169-
str(inspect.signature(orjson.dumps)), "(obj, /, default, option)"
169+
str(inspect.signature(orjson.dumps)), "(obj, /, default=None, option=None)"
170170
)
171+
inspect.signature(orjson.dumps).bind("str")
172+
inspect.signature(orjson.dumps).bind("str", default=default, option=1)
171173

172174
def test_loads_signature(self):
173175
"""
174176
loads() valid __text_signature__
175177
"""
176178
self.assertEqual(str(inspect.signature(orjson.loads)), "(obj, /)")
179+
inspect.signature(orjson.loads).bind("[]")
177180

178181
def test_bytes_buffer(self):
179182
"""

0 commit comments

Comments
 (0)