Skip to content

Commit 0c156cc

Browse files
committed
Fixed some md issues in Contributing and Readme.
Fixed game reference in Emitter.
1 parent eddf1ed commit 0c156cc

3 files changed

Lines changed: 9 additions & 7 deletions

File tree

CONTRIBUTING.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,13 @@ It's important to us that you feel you can contribute towards the evolution of P
99

1010
1. **Search for existing issues.** Your bug may have already been fixed or addressed in a development branch version of Phaser, so be sure to search the issues first before putting in a duplicate issue.
1111

12-
2. **Create an isolated and reproducible test case.** If you are reporting a bug, make sure you also have a minimal, runnable, code example that reproduces the problem you have.
12+
2. **Not sure if it's a bug?.** Then please ask on the forum. If something is blatantly wrong then post it to github. But if you feel it might just be because you're not sure of expected behaviour, then it might save us time, and get you a response faster, if you post it to the Phaser forum instead.
1313

14-
3. **Include a live example.** After narrowing your code down to only the problem areas, make use of [jsFiddle][1], [jsBin][2], or a link to your live site so that we can view a live example of the problem.
14+
3. **Create an isolated and reproducible test case.** If you are reporting a bug, make sure you also have a minimal, runnable, code example that reproduces the problem you have.
1515

16-
4. **Share as much information as possible.** Include browser version affected, your OS, version of the library, steps to reproduce, etc. "X isn't working!!!1!" will probably just be closed.
16+
4. **Include a live example.** After narrowing your code down to only the problem areas, make use of [jsFiddle][1], [jsBin][2], or a link to your live site so that we can view a live example of the problem.
17+
18+
5. **Share as much information as possible.** Include browser version affected, your OS, version of the library, steps to reproduce, etc. "X isn't working!!!1!" will probably just be closed.
1719

1820

1921
##Pixi and Phaser
@@ -35,7 +37,7 @@ The dev branch of Phaser is our 'current working' version. It is always ahead of
3537

3638
To take advantage of our grunt build script and jshint config it will be easiest for you if you have node.js and grunt installed locally.
3739

38-
You can download node.js from [nodejs.org][3]. After it has been installed open a console and run `npm i - g grunt - cli` to install the global `grunt` executable.
40+
You can download node.js from [nodejs.org][3]. After it has been installed open a console and run `npm i -g grunt -cli` to install the global `grunt` executable.
3941

4042
After that you can clone the repository and run `npm i` inside the cloned folder. This will install dependencies necessary for building the project. Once that is ready,
4143
make your changes and submit a Pull Request:
@@ -60,7 +62,7 @@ That is fine too. While Pull Requests are the best thing in the world for us, th
6062

6163
- No trailing whitespace, blank lines should have no whitespace.
6264

63-
- Always favor strict equals` === `unless you * need * to use type coercion.
65+
- Always favor strict equals `===` unless you *need* to use type coercion.
6466

6567
- Follow conventions already in the code, and listen to jshint. Our config is set-up for a reason.
6668

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ New Features
143143

144144
There is an extensive [Migration Guide](https://github.com/photonstorm/phaser/blob/master/resources/Migration%20Guide.md) available. In the guide we detail the API breaking changes and approach to our new physics system. For a list of all the other new features, updates and bug fixes present in 2.0 please see the Change Log.
145145

146-
The Change Log for all previous versions is at https://github.com/photonstorm/phaser/changelog.md
146+
The Change Log for all previous versions is at https://github.com/photonstorm/phaser/blob/master/changelog.md
147147

148148

149149
How to Build

src/particles/arcade/Emitter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ Phaser.Particles.Arcade.Emitter.prototype.makeParticles = function (keys, frames
285285

286286
particle = new this.particleClass(this.game, 0, 0, rndKey, rndFrame);
287287

288-
game.physics.arcade.enable(particle, false);
288+
this.game.physics.arcade.enable(particle, false);
289289

290290
if (collide)
291291
{

0 commit comments

Comments
 (0)