moved create method meant for instantiating global sound manager object form BaseSoundManager class to dedicated SoundManagerCreator class

moved setting local game reference from WebAudioSoundManager class to BaseSoundManager class constructor
fixed bug with audio context creation condition in WebAudioSoundManager class

Author: pavle-goloskokovic

v3/src/boot/Game.js

@@ -17,7 +17,7 @@ var GlobalInputManager = require('../input/global/GlobalInputManager');
 var GlobalSceneManager = require('../scene/global/GlobalSceneManager');
 var TextureManager = require('../textures/TextureManager');
 var TimeStep = require('./TimeStep');
-var BaseSoundManager = require('../sound/BaseSoundManager');
+var SoundManagerCreator = require('../sound/SoundManagerCreator');
 
 var Game = new Class({
 
@@ -138,7 +138,7 @@ var Game = new Class({
          *
          * @property {Phaser.BaseSoundManager} sound
          */
-        this.sound = BaseSoundManager.create(this);
+        this.sound = SoundManagerCreator.create(this);
 
         /**
          * [description]

v3/src/sound/BaseSoundManager.js

@@ -1,31 +1,21 @@
 var Class = require('../utils/Class');
-var WebAudioSoundManager = require('./WebAudioSoundManager');
 
 //  Phaser.Loader.BaseSoundManager
 
 var BaseSoundManager = new Class({
 
     // TODO define sound manager interface
 
-});
-
-BaseSoundManager.create = function (game)
-{
-    var audioConfig = game.config.audio;
-    var deviceAudio = game.device.Audio;
-
-    if ((audioConfig && audioConfig.noAudio) || (!deviceAudio.webAudio && !deviceAudio.audioData))
-    {
-        return new BaseSoundManager(game);
-    }
+    initialize:
 
-    if(deviceAudio.webAudio && !(audioConfig && audioConfig.disableWebAudio))
+    function BaseSoundManager (game)
     {
-        return new WebAudioSoundManager(game);
+        /**
+         * @property {Phaser.Game} game - Local reference to game.
+         */
+        this.game = game;
     }
 
-    // TODO return HTML5 Audio sound manager
-    return new BaseSoundManager(game);
-};
+});
 
 module.exports = BaseSoundManager;

v3/src/sound/SoundManagerCreator.js

@@ -0,0 +1,28 @@
+var BaseSoundManager = require('./BaseSoundManager');
+var WebAudioSoundManager = require('./WebAudioSoundManager');
+
+var SoundManagerCreator = {
+
+    create: function (game)
+    {
+        var audioConfig = game.config.audio;
+        var deviceAudio = game.device.Audio;
+
+        if ((audioConfig && audioConfig.noAudio) || (!deviceAudio.webAudio && !deviceAudio.audioData))
+        {
+            // TODO add no audio implementation of BaseSoundManager
+            return new BaseSoundManager(game);
+        }
+
+        if(deviceAudio.webAudio && !(audioConfig && audioConfig.disableWebAudio))
+        {
+            return new WebAudioSoundManager(game);
+        }
+
+        // TODO return HTML5 Audio sound manager
+        return new BaseSoundManager(game);
+    }
+
+};
+
+module.exports = SoundManagerCreator;

v3/src/sound/WebAudioSoundManager.js

@@ -11,10 +11,7 @@ var WebAudioSoundManager = new Class({
 
     function WebAudioSoundManager (game)
     {
-        /**
-         * @property {Phaser.Game} game - Local reference to game.
-         */
-        this.game = game;
+        BaseSoundManager.call(this, game);
 
         /**
          * @property {AudioContext} context - The AudioContext being used for playback.
@@ -25,9 +22,11 @@ var WebAudioSoundManager = new Class({
 
     createAudioContext: function ()
     {
-        if (this.game.config.audio.context)
+        var audioConfig = this.game.config.audio;
+
+        if (audioConfig && audioConfig.context)
         {
-            return this.game.config.audio.context;
+            return audioConfig.context;
         }
 
         return new (window['AudioContext'] || window['webkitAudioContext'])();