Updated RandomDataGenerator.shuffle to remove several internal calls as min is always zero

Author: photonstorm

CHANGELOG.md

@@ -7,6 +7,7 @@
 * The Phaser 3 Labs has gained a nifty 'search' feature box thanks to @NemoStein - it allows you to filter out the example categories.
 * We've added a Mask component, which is available on nearly all Game Objects. It includes the methods `setMask`, `clearMask`, `createBitmapMask` and `createGeometryMask`.
 * CanvasTexture is a new extension of the Texture object specifically created for when you've got a Canvas element as the backing source of the texture that you wish to draw to programmatically using the Canvas API. This was possible in previous versions, as a Texture object supported having a Canvas as its source, but we've streamlined the process and made it a lot easier for you to refresh the resulting WebGLTexture on the GPU. To create a CanvasTexture just call the `TextureManager.createCanvas` method as before, only this time you'll get a CanvasTexture back which has helper properties and methods. See the complete JSDocs for more details.
+* RandomDataGenerator has a new method: `shuffle` which allows you to shuffle an array using the current RNG seed (thanks @wtravO)
 
 ### Updates
 
@@ -37,6 +38,7 @@
 
 * DataManagerPlugin would throw an error on Game.destroy if you had any Scenes in the Scene Manager had not been run. Fix #3596 (thanks @kuoruan)
 * If you created a Game with no Scenes defined, and then added one via `Game.scene.add` and passed in a data object, the data would be ignored when starting the Scene.
+* Adding a Group with an array of children in the constructor was broken since 3.5. Fix #3612 (thanks @fariazz @samme)
 
 ### Examples, Documentation and TypeScript
 

src/math/random-data-generator/RandomDataGenerator.js

@@ -452,10 +452,10 @@ var RandomDataGenerator = new Class({
     },
 
     /**
-     * A standard array shuffle implementation using the current seed.
+     * Shuffles the given array, using the current seed.
      *
      * @method Phaser.Math.RandomDataGenerator#shuffle
-     * @since 3.4.0
+     * @since 3.7.0
      * 
      * @param {array[]} [array] - The array to be shuffled.
      *
@@ -464,14 +464,16 @@ var RandomDataGenerator = new Class({
     shuffle: function (array)
     {
         var len = array.length - 1;
+
         for (var i = len; i > 0; i--)
         {
-            var randomIndex = this.integerInRange(0, len);
+            var randomIndex = Math.floor(this.frac() * (len + 1));
             var itemAtIndex = array[randomIndex];
 
             array[randomIndex] = array[i];
             array[i] = itemAtIndex;
         }
+
         return array;
     }