Keyboard.JustDown and Keyboard.JustUp were being reset too early, causing them to fail when called in update loops. Fix phaserjs#3490

Author: photonstorm

CHANGELOG.md

@@ -31,6 +31,7 @@ being passed to the simulation. The default value is 1 to remain consistent with
 * The HueToComponent module was not correctly exporting itself. Fix #3482 (thanks @jdotrjs)
 * Matter.World was using `setZ` instead of `setDepth` for the Debug Graphics Layer, causing it to appear behind objects in some display lists.
 * Game.destroy now checks to see if the `renderer` exists before calling destroy on it. Fix #3498 (thanks @Huararanga)
+* Keyboard.JustDown and Keyboard.JustUp were being reset too early, causing them to fail when called in `update` loops. Fix #3490 (thanks @belen-albeza)
 
 ### Updates
 

src/input/keyboard/keys/JustDown.js

@@ -19,15 +19,16 @@
  */
 var JustDown = function (key)
 {
-    var current = false;
-
-    if (key.isDown)
+    if (key._justDown)
     {
-        current = key._justDown;
         key._justDown = false;
-    }
 
-    return current;
+        return true;
+    }
+    else
+    {
+        return false;
+    }
 };
 
 module.exports = JustDown;

src/input/keyboard/keys/JustUp.js

@@ -19,15 +19,16 @@
  */
 var JustUp = function (key)
 {
-    var current = false;
-
-    if (key.isDown)
+    if (key._justUp)
     {
-        current = key._justUp;
         key._justUp = false;
-    }
 
-    return current;
+        return true;
+    }
+    else
+    {
+        return false;
+    }
 };
 
 module.exports = JustUp;

src/input/keyboard/keys/ProcessKeyDown.js

@@ -40,13 +40,12 @@ var ProcessKeyDown = function (key, event)
         key.isUp = false;
         key.timeDown = event.timeStamp;
         key.duration = 0;
+        key._justDown = true;
+        key._justUp = false;
     }
 
     key.repeats++;
 
-    key._justDown = true;
-    key._justUp = false;
-
     return key;
 };
 

src/input/keyboard/keys/ResetKey.js

@@ -5,8 +5,8 @@
  */
 
 /**
- *  Resets a Key object back to its default settings.
- *  Optionally resets the keyCode as well.
+ * Resets a Key object back to its default settings.
+ * Optionally resets the keyCode as well.
  *
  * @function Phaser.Input.Keyboard.Keys.ResetKey
  * @since 3.0.0