Merge pull request phaserjs#5055 from samme/fix/html5audio-volume

photonstorm · web-flow · commit 1dd3d4e3729b · 2020-04-27T10:08:55.000+01:00
Clamp audio tag volume in HTML5AudioSound
diff --git a/src/sound/html5/HTML5AudioSound.js b/src/sound/html5/HTML5AudioSound.js
@@ -8,6 +8,7 @@
 var BaseSound = require('../BaseSound');
 var Class = require('../../utils/Class');
 var Events = require('../events');
+var Clamp = require('../../math/Clamp');
 
 /**
  * @classdesc
@@ -552,7 +553,7 @@ var HTML5AudioSound = new Class({
     {
         if (this.audio)
         {
-            this.audio.volume = this.currentConfig.volume * this.manager.volume;
+            this.audio.volume = Clamp(this.currentConfig.volume * this.manager.volume, 0, 1);
         }
     },
 

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@`
`8`	`8`	`var BaseSound = require('../BaseSound');`
`9`	`9`	`var Class = require('../../utils/Class');`
`10`	`10`	`var Events = require('../events');`
	`11`	`+var Clamp = require('../../math/Clamp');`
`11`	`12`
`12`	`13`	`/**`
`13`	`14`	`* @classdesc`
`@@ -552,7 +553,7 @@ var HTML5AudioSound = new Class({`
`552`	`553`	`{`
`553`	`554`	`if (this.audio)`
`554`	`555`	`{`
`555`		`- this.audio.volume = this.currentConfig.volume * this.manager.volume;`
	`556`	`+ this.audio.volume = Clamp(this.currentConfig.volume * this.manager.volume, 0, 1);`
`556`	`557`	`}`
`557`	`558`	`},`
`558`	`559`