Pass the pointers array in directly, no need to iterate them all every time

Author: photonstorm

CHANGELOG.md

@@ -55,8 +55,8 @@ The following changes took place in the Pointer class:
 * Calling `setPollAlways()` would cause the `'pointerdown'` event to fire multiple times. Fix #4541 (thanks @Neyromantik)
 * The pointer events were intermittently not registered, causing `pointerup` to often fail. Fix #4538 (thanks @paulsymphony)
 * Due to a regression in 3.16 the drag events were not performing as fast as before, causing drags to feel lagged. Fix #4500 (thanks @aliblong)
+* Over and Out events should now work for any pointer in multi-touch environments, not just the first touch pointer registered.
 
-TODO: No need to iterate pointers in `update` any more, can pass in from manager handler.
 
 ### New Features
 

src/input/InputManager.js

@@ -291,6 +291,16 @@ var InputManager = new Class({
          */
         this._tempSkip = false;
 
+        /**
+         * An internal private array that avoids needing to create a new array on every DOM mouse event.
+         *
+         * @name Phaser.Input.InputManager#mousePointerContainer
+         * @type {Phaser.Input.Pointer[]}
+         * @private
+         * @since 3.18.0
+         */
+        this.mousePointerContainer = [ this.mousePointer ];
+
         game.events.once(GameEvents.BOOT, this.boot, this);
     },
 
@@ -678,13 +688,12 @@ var InputManager = new Class({
      * @method Phaser.Input.InputManager#updateInputPlugins
      * @since 3.16.0
      *
-     * @param {number} time - The time value from the most recent Game step. Typically a high-resolution timer value, or Date.now().
-     * @param {number} delta - The delta value since the last frame. This is smoothed to avoid delta spikes by the TimeStep class.
+     * @param {integer} type - The type of event to process.
+     * @param {Phaser.Input.Pointer[]} pointers - An array of Pointers on which the event occurred.
      */
-    updateInputPlugins: function (type, time)
+    updateInputPlugins: function (type, pointers)
     {
         var scenes = this.game.scene.getScenes(true, true);
-        var delta = this.game.loop.delta;
 
         this._tempSkip = false;
 
@@ -694,7 +703,7 @@ var InputManager = new Class({
 
             if (scene.sys.input)
             {
-                var capture = scene.sys.input.update(type, time, delta);
+                var capture = scene.sys.input.update(type, pointers);
 
                 if ((capture && this.globalTopOnly) || this._tempSkip)
                 {
@@ -723,7 +732,7 @@ var InputManager = new Class({
             pointer.updateMotion();
         });
 
-        this.updateInputPlugins(CONST.TOUCH_START, event.timeStamp);
+        this.updateInputPlugins(CONST.TOUCH_START, event.timeStamp, changed);
     },
 
     /**
@@ -744,7 +753,7 @@ var InputManager = new Class({
             pointer.updateMotion();
         });
 
-        this.updateInputPlugins(CONST.TOUCH_MOVE, event.timeStamp);
+        this.updateInputPlugins(CONST.TOUCH_MOVE, event.timeStamp, changed);
     },
 
     /**
@@ -765,7 +774,7 @@ var InputManager = new Class({
             pointer.updateMotion();
         });
 
-        this.updateInputPlugins(CONST.TOUCH_END, event.timeStamp);
+        this.updateInputPlugins(CONST.TOUCH_END, event.timeStamp, changed);
     },
 
     /**
@@ -786,7 +795,7 @@ var InputManager = new Class({
             pointer.updateMotion();
         });
 
-        this.updateInputPlugins(CONST.TOUCH_CANCEL, event.timeStamp);
+        this.updateInputPlugins(CONST.TOUCH_CANCEL, event.timeStamp, changed);
     },
 
     /**
@@ -804,7 +813,7 @@ var InputManager = new Class({
 
         this.mousePointer.updateMotion();
 
-        this.updateInputPlugins(CONST.MOUSE_DOWN, event.timeStamp);
+        this.updateInputPlugins(CONST.MOUSE_DOWN, event.timeStamp, this.mousePointerContainer);
     },
 
     /**
@@ -822,7 +831,7 @@ var InputManager = new Class({
 
         this.mousePointer.updateMotion();
 
-        this.updateInputPlugins(CONST.MOUSE_MOVE, event.timeStamp);
+        this.updateInputPlugins(CONST.MOUSE_MOVE, event.timeStamp, this.mousePointerContainer);
     },
 
     /**
@@ -840,7 +849,7 @@ var InputManager = new Class({
 
         this.mousePointer.updateMotion();
 
-        this.updateInputPlugins(CONST.MOUSE_UP, event.timeStamp);
+        this.updateInputPlugins(CONST.MOUSE_UP, event.timeStamp, this.mousePointerContainer);
     },
 
     /**

src/input/InputPlugin.js

@@ -630,21 +630,19 @@ var InputPlugin = new Class({
      * @fires Phaser.Input.Events#UPDATE
      * @since 3.0.0
      *
-     * @param {integer} type - The type of input event to process.
+     * @param {integer} type - The type of event to process.
+     * @param {Phaser.Input.Pointer[]} pointers - An array of Pointers on which the event occurred.
      * 
      * @return {boolean} `true` if this Scene has captured the input events from all other Scenes, otherwise `false`.
      */
-    update: function (type)
+    update: function (type, pointers)
     {
         if (!this.isActive())
         {
             return false;
         }
 
-        var manager = this.manager;
-
-        var pointers = manager.pointers;
-        var pointersTotal = manager.pointersTotal;
+        var pointersTotal = pointers.length;
         var captured = false;
 
         for (var i = 0; i < pointersTotal; i++)