Updated Device.isConsoleOpen as it no longer works in Chrome. Revised code and documentation accordingly (fix phaserjs#593)

Revised p2 clear process.

Author: photonstorm

README.md

@@ -67,6 +67,10 @@ Bug Fixes
 * Removed the examples build script from the Gruntfile (fix #592)
 * The P2 World wouldn't clear down fully on a State change, now properly clears out contacts, resets the bitmask, etc.
 
+Updated:
+
+* Updated Device.isConsoleOpen as it no longer works in Chrome. Revised code and documentation accordingly (fix #593)
+
 
 TODO:
 

src/physics/p2/World.js

@@ -651,7 +651,7 @@ Phaser.Physics.P2.prototype = {
     },
 
     /**
-    * Clears all bodies from the simulation.
+    * Clears all bodies from the simulation, resets callbacks and resets the collision bitmask.
     *
     * @method Phaser.Physics.P2#clear
     */
@@ -662,13 +662,13 @@ Phaser.Physics.P2.prototype = {
         this.world.off("beginContact", this.beginContactHandler, this);
         this.world.off("endContact", this.endContactHandler, this);
 
+        this.setPostBroadphaseCallback(null);
+        this.setImpactEvents(null);
+
         this.collisionGroups = [];
         this._toRemove = [];
-        this.boundsCollidesWith = [];
         this._collisionGroupID = 2;
-        this.postBroadphaseCallback = null;
-        this.callbackContext = null;
-        this.impactCallback = null;
+        this.boundsCollidesWith = [];
 
     },
 

src/system/Device.js

@@ -753,6 +753,9 @@ Phaser.Device.prototype = {
 
     /**
     * Check whether the console is open.
+    * Note that this only works in Firefox with Firebug and earlier versions of Chrome.
+    * It used to work in Chrome, but then they removed the ability: http://src.chromium.org/viewvc/blink?view=revision&revision=151136
+    * 
     * @method Phaser.Device#isConsoleOpen
     * @return {boolean} True if the browser dev console is open.
     */
@@ -773,7 +776,10 @@ Phaser.Device.prototype = {
                 console.clear();
             }
 
-            return console['profiles'].length > 0;
+            if (console['profiles'])
+            {
+                return console['profiles'].length > 0;
+            }
         }
 
         return false;