Skip to content

Commit 51aaa3e

Browse files
Fixed bug with EventBinding which gets destroyed mid execution - removed logic that was already executed either through binding destroy call or dispatcher destroy call
Fixed issue where comparison was performed instead of assignment
1 parent 78c7473 commit 51aaa3e

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

v3/src/events/EventBinding.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -190,10 +190,6 @@ var EventBinding = new Class({
190190
// All done, tidy the list in case there were any pending events added
191191
this.tidy();
192192
}
193-
else if (this.state === CONST.DISPATCHER_DESTROYED)
194-
{
195-
this.dispatcher.delete(this.type);
196-
}
197193
else
198194
{
199195
// All done, just purge the list
@@ -246,7 +242,7 @@ var EventBinding = new Class({
246242
}
247243
else if (this.active[i].state === CONST.LISTENER_PENDING)
248244
{
249-
this.active[i].state === CONST.LISTENER_ACTIVE;
245+
this.active[i].state = CONST.LISTENER_ACTIVE;
250246
added++;
251247
}
252248

0 commit comments

Comments
 (0)