Skip to content

Commit 67ea16e

Browse files
committed
Fixed bug in AnimationConfig jsdoc and filled in several empty descriptions
1 parent 6772a54 commit 67ea16e

1 file changed

Lines changed: 13 additions & 11 deletions

File tree

src/animations/Animation.js

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ var GetValue = require('../utils/object/GetValue');
1313
/**
1414
* @typedef {object} JSONAnimation
1515
*
16-
* @property {string} key - [description]
16+
* @property {string} key - The key that the animation will be associated with. i.e. sprite.animations.play(key)
1717
* @property {string} type - A frame based animation (as opposed to a bone based animation)
1818
* @property {JSONAnimationFrame[]} frames - [description]
1919
* @property {integer} frameRate - The frame rate of playback in frames per second (default 24 if duration is null)
@@ -30,7 +30,7 @@ var GetValue = require('../utils/object/GetValue');
3030
/**
3131
* @typedef {object} AnimationFrameConfig
3232
*
33-
* @property {string} key - [description]
33+
* @property {string} key - The key that the animation will be associated with. i.e. sprite.animations.play(key)
3434
* @property {(string|number)} frame - [description]
3535
* @property {float} [duration=0] - [description]
3636
* @property {boolean} [visible] - [description]
@@ -39,8 +39,9 @@ var GetValue = require('../utils/object/GetValue');
3939
/**
4040
* @typedef {object} AnimationConfig
4141
*
42-
* @property {AnimationFrameConfig[]} [frames] - [description]
43-
* @property {string} [defaultTextureKey=null] - [description]
42+
* @property {string} [key] - The key that the animation will be associated with. i.e. sprite.animations.play(key)
43+
* @property {AnimationFrameConfig[]} [frames] - An object containing data used to generate the frames for the animation
44+
* @property {string} [defaultTextureKey=null] - The key of the texture all frames of the animation will use. Can be overridden on a per frame basis.
4445
* @property {integer} [frameRate] - The frame rate of playback in frames per second (default 24 if duration is null)
4546
* @property {integer} [duration] - How long the animation should play for in milliseconds. If not given its derived from frameRate.
4647
* @property {boolean} [skipMissedFrames=true] - Skip frames if the time lags, or always advanced anyway?
@@ -78,7 +79,7 @@ var Animation = new Class({
7879
function Animation (manager, key, config)
7980
{
8081
/**
81-
* [description]
82+
* A reference to the global Animation Manager
8283
*
8384
* @name Phaser.Animations.Animation#manager
8485
* @type {Phaser.Animations.AnimationManager}
@@ -87,7 +88,7 @@ var Animation = new Class({
8788
this.manager = manager;
8889

8990
/**
90-
* [description]
91+
* The unique identifying string for this animation
9192
*
9293
* @name Phaser.Animations.Animation#key
9394
* @type {string}
@@ -366,15 +367,15 @@ var Animation = new Class({
366367
},
367368

368369
/**
369-
* [description]
370+
* Returns the AnimationFrame at the provided index
370371
*
371372
* @method Phaser.Animations.Animation#getFrameAt
372373
* @protected
373374
* @since 3.0.0
374375
*
375-
* @param {integer} index - [description]
376+
* @param {integer} index - The index in the AnimationFrame array
376377
*
377-
* @return {Phaser.Animations.AnimationFrame} [description]
378+
* @return {Phaser.Animations.AnimationFrame} The frame at the index provided from the animation sequence
378379
*/
379380
getFrameAt: function (index)
380381
{
@@ -660,12 +661,13 @@ var Animation = new Class({
660661
},
661662

662663
/**
663-
* [description]
664+
* Removes a frame from the AnimationFrame array at the provided index
665+
* and updates the animation accordingly.
664666
*
665667
* @method Phaser.Animations.Animation#removeFrameAt
666668
* @since 3.0.0
667669
*
668-
* @param {integer} index - [description]
670+
* @param {integer} index - The index in the AnimationFrame array
669671
*
670672
* @return {Phaser.Animations.Animation} This Animation object.
671673
*/

0 commit comments

Comments
 (0)