Skip to content

Commit 6af8070

Browse files
committed
Fixed all of the Shape WebGL rendering issues
1 parent e0295e8 commit 6af8070

13 files changed

Lines changed: 18 additions & 34 deletions

src/gameobjects/shape/FillPathWebGL.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,7 @@ var FillPathWebGL = function (pipeline, calcMatrix, src, alpha, dx, dy)
4949
var tx2 = calcMatrix.getX(x2, y2);
5050
var ty2 = calcMatrix.getY(x2, y2);
5151

52-
pipeline.setTexture2D();
53-
54-
pipeline.batchTri(tx0, ty0, tx1, ty1, tx2, ty2, 0, 0, 1, 1, fillTintColor, fillTintColor, fillTintColor, pipeline.tintEffect);
52+
pipeline.batchTri(tx0, ty0, tx1, ty1, tx2, ty2, fillTintColor, fillTintColor, fillTintColor);
5553
}
5654
};
5755

src/gameobjects/shape/StrokePathWebGL.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ var StrokePathWebGL = function (pipeline, src, alpha, dx, dy)
4747
var px2 = path[i] - dx;
4848
var py2 = path[i + 1] - dy;
4949

50-
pipeline.setTexture2D();
51-
5250
pipeline.batchLine(
5351
px1,
5452
py1,

src/gameobjects/shape/arc/ArcWebGLRenderer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ var ArcWebGLRenderer = function (renderer, src, camera, parentMatrix)
2828

2929
var result = GetCalcMatrix(src, camera, parentMatrix);
3030

31-
var calcMatrix = renderer._tempMatrix1.copyFrom(result.calc);
31+
var calcMatrix = pipeline.calcMatrix.copyFrom(result.calc);
3232

3333
var dx = src._displayOriginX;
3434
var dy = src._displayOriginY;

src/gameobjects/shape/curve/CurveWebGLRenderer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ var CurveWebGLRenderer = function (renderer, src, camera, parentMatrix)
2828

2929
var result = GetCalcMatrix(src, camera, parentMatrix);
3030

31-
var calcMatrix = renderer._tempMatrix3.copyFrom(result.calc);
31+
var calcMatrix = pipeline.calcMatrix.copyFrom(result.calc);
3232

3333
var dx = src._displayOriginX + src._curveBounds.x;
3434
var dy = src._displayOriginY + src._curveBounds.y;

src/gameobjects/shape/ellipse/EllipseWebGLRenderer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ var EllipseWebGLRenderer = function (renderer, src, camera, parentMatrix)
2828

2929
var result = GetCalcMatrix(src, camera, parentMatrix);
3030

31-
var calcMatrix = renderer._tempMatrix3.copyFrom(result.calc);
31+
var calcMatrix = pipeline.calcMatrix.copyFrom(result.calc);
3232

3333
var dx = src._displayOriginX;
3434
var dy = src._displayOriginY;

src/gameobjects/shape/grid/GridWebGLRenderer.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ var GridWebGLRenderer = function (renderer, src, camera, parentMatrix)
2727

2828
var result = GetCalcMatrix(src, camera, parentMatrix);
2929

30-
var calcMatrix = renderer._tempMatrix3.copyFrom(result.calc);
30+
var calcMatrix = pipeline.calcMatrix.copyFrom(result.calc);
3131

3232
calcMatrix.translate(-src._displayOriginX, -src._displayOriginY);
3333

@@ -63,8 +63,6 @@ var GridWebGLRenderer = function (renderer, src, camera, parentMatrix)
6363
var cw = 0;
6464
var ch = 0;
6565

66-
pipeline.setTexture2D();
67-
6866
if (showOutline)
6967
{
7068
// To make room for the grid lines (in case alpha < 1)

src/gameobjects/shape/isobox/IsoBoxWebGLRenderer.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ var IsoBoxWebGLRenderer = function (renderer, src, camera, parentMatrix)
2727

2828
var result = GetCalcMatrix(src, camera, parentMatrix);
2929

30-
var calcMatrix = renderer._tempMatrix3.copyFrom(result.calc);
30+
var calcMatrix = pipeline.calcMatrix.copyFrom(result.calc);
3131

3232
var size = src.width;
3333
var height = src.height;
@@ -56,8 +56,6 @@ var IsoBoxWebGLRenderer = function (renderer, src, camera, parentMatrix)
5656
var x3;
5757
var y3;
5858

59-
pipeline.setTexture2D();
60-
6159
// Top Face
6260

6361
if (src.showTop)
@@ -76,7 +74,7 @@ var IsoBoxWebGLRenderer = function (renderer, src, camera, parentMatrix)
7674
x3 = calcMatrix.getX(0, sizeB - height);
7775
y3 = calcMatrix.getY(0, sizeB - height);
7876

79-
pipeline.batchQuad(x0, y0, x1, y1, x2, y2, x3, y3, 0, 0, 1, 1, tint, tint, tint, tint, 1);
77+
pipeline.batchQuad(x0, y0, x1, y1, x2, y2, x3, y3, tint, tint, tint, tint);
8078
}
8179

8280
// Left Face
@@ -97,7 +95,7 @@ var IsoBoxWebGLRenderer = function (renderer, src, camera, parentMatrix)
9795
x3 = calcMatrix.getX(-sizeA, -height);
9896
y3 = calcMatrix.getY(-sizeA, -height);
9997

100-
pipeline.batchQuad(x0, y0, x1, y1, x2, y2, x3, y3, 0, 0, 1, 1, tint, tint, tint, tint, 1);
98+
pipeline.batchQuad(x0, y0, x1, y1, x2, y2, x3, y3, tint, tint, tint, tint);
10199
}
102100

103101
// Right Face
@@ -118,7 +116,7 @@ var IsoBoxWebGLRenderer = function (renderer, src, camera, parentMatrix)
118116
x3 = calcMatrix.getX(sizeA, -height);
119117
y3 = calcMatrix.getY(sizeA, -height);
120118

121-
pipeline.batchQuad(x0, y0, x1, y1, x2, y2, x3, y3, 0, 0, 1, 1, tint, tint, tint, tint, 1);
119+
pipeline.batchQuad(x0, y0, x1, y1, x2, y2, x3, y3, tint, tint, tint, tint);
122120
}
123121
};
124122

src/gameobjects/shape/isotriangle/IsoTriangleWebGLRenderer.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ var IsoTriangleWebGLRenderer = function (renderer, src, camera, parentMatrix)
2727

2828
var result = GetCalcMatrix(src, camera, parentMatrix);
2929

30-
var calcMatrix = renderer._tempMatrix3.copyFrom(result.calc);
30+
var calcMatrix = pipeline.calcMatrix.copyFrom(result.calc);
3131

3232
var size = src.width;
3333
var height = src.height;
@@ -55,8 +55,6 @@ var IsoTriangleWebGLRenderer = function (renderer, src, camera, parentMatrix)
5555
var x2;
5656
var y2;
5757

58-
pipeline.setTexture2D();
59-
6058
// Top Face
6159

6260
if (src.showTop && reversed)
@@ -75,7 +73,7 @@ var IsoTriangleWebGLRenderer = function (renderer, src, camera, parentMatrix)
7573
var x3 = calcMatrix.getX(0, sizeB - height);
7674
var y3 = calcMatrix.getY(0, sizeB - height);
7775

78-
pipeline.batchQuad(x0, y0, x1, y1, x2, y2, x3, y3, 0, 0, 1, 1, tint, tint, tint, tint, 1);
76+
pipeline.batchQuad(x0, y0, x1, y1, x2, y2, x3, y3, tint, tint, tint, tint);
7977
}
8078

8179
// Left Face
@@ -107,7 +105,7 @@ var IsoTriangleWebGLRenderer = function (renderer, src, camera, parentMatrix)
107105
y2 = calcMatrix.getY(0, sizeB - height);
108106
}
109107

110-
pipeline.batchTri(x0, y0, x1, y1, x2, y2, 0, 0, 1, 1, tint, tint, tint, 1);
108+
pipeline.batchTri(x0, y0, x1, y1, x2, y2, tint, tint, tint);
111109
}
112110

113111
// Right Face
@@ -139,7 +137,7 @@ var IsoTriangleWebGLRenderer = function (renderer, src, camera, parentMatrix)
139137
y2 = calcMatrix.getY(0, sizeB - height);
140138
}
141139

142-
pipeline.batchTri(x0, y0, x1, y1, x2, y2, 0, 0, 1, 1, tint, tint, tint, 1);
140+
pipeline.batchTri(x0, y0, x1, y1, x2, y2, tint, tint, tint);
143141
}
144142
};
145143

src/gameobjects/shape/line/LineWebGLRenderer.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ var LineWebGLRenderer = function (renderer, src, camera, parentMatrix)
2727

2828
var result = GetCalcMatrix(src, camera, parentMatrix);
2929

30-
renderer._tempMatrix3.copyFrom(result.calc);
30+
pipeline.calcMatrix.copyFrom(result.calc);
3131

3232
var dx = src._displayOriginX;
3333
var dy = src._displayOriginY;
@@ -46,8 +46,6 @@ var LineWebGLRenderer = function (renderer, src, camera, parentMatrix)
4646
var startWidth = src._startWidth;
4747
var endWidth = src._endWidth;
4848

49-
pipeline.setTexture2D();
50-
5149
pipeline.batchLine(
5250
src.geom.x1 - dx,
5351
src.geom.y1 - dy,

src/gameobjects/shape/polygon/PolygonWebGLRenderer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ var PolygonWebGLRenderer = function (renderer, src, camera, parentMatrix)
2828

2929
var result = GetCalcMatrix(src, camera, parentMatrix);
3030

31-
var calcMatrix = renderer._tempMatrix3.copyFrom(result.calc);
31+
var calcMatrix = pipeline.calcMatrix.copyFrom(result.calc);
3232

3333
var dx = src._displayOriginX;
3434
var dy = src._displayOriginY;

0 commit comments

Comments
 (0)