Looped Tween Timelines would mess-up the tween values on every loop repeat, causing the loop to fail. They now loop correctly due to a fix in the Tween.play method. Fix phaserjs#4558

Author: photonstorm

CHANGELOG.md

@@ -183,6 +183,7 @@ The following changes took place in the Pointer class:
 * Setting `random: false` in a Particle Emitter config option no longer causes it to think random is true (thanks @samme)
 * `Zone.setSize` didn't update the displayOrigin, causing touch events to be inaccurate as the origin was out. Fix #4131 (thanks @rexrainbow)
 * `Tween.restart` wouldn't restart the tween properly. Fix #4594 (thanks @NokFrt)
+* Looped Tween Timelines would mess-up the tween values on every loop repeat, causing the loop to fail. They now loop correctly due to a fix in the Tween.play method. Fix #4558 (thanks @peteroravec)
 
 ### Examples, Documentation and TypeScript
 

src/tweens/Timeline.js

@@ -628,9 +628,6 @@ var Timeline = new Class({
         if (this.loopCounter > 0)
         {
             //  Reset the elapsed time
-            //  TODO: Probably ought to be set to the remainder from elapsed - duration
-            //  as the tweens nearly always over-run by a few ms due to rAf
-
             this.elapsed = 0;
             this.progress = 0;
 

src/tweens/tween/Tween.js

@@ -665,7 +665,7 @@ var Tween = new Class({
         {
             return this;
         }
-        else if (this.state === TWEEN_CONST.PENDING_REMOVE || this.state === TWEEN_CONST.REMOVED)
+        else if (!this.parentIsTimeline && (this.state === TWEEN_CONST.PENDING_REMOVE || this.state === TWEEN_CONST.REMOVED))
         {
             this.seek(0);
             this.parent.makeActive(this);