Skip to content

Commit 6d8afe9

Browse files
committed
tweenData.end should be seeded with the start value, not the current one, or relative tweens break upon repeat.
1 parent 0d38e23 commit 6d8afe9

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

v3/src/tweens/tween/inc/UpdateTweenData.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ var SetStateFromEnd = function (tween, tweenData, diff)
3333
onYoyo.func.apply(onYoyo.scope, onYoyo.params);
3434
}
3535

36+
// console.log('SetStateFromEnd-a', tweenData.start, tweenData.end);
37+
3638
tweenData.start = tweenData.getStartValue(tweenData.target, tweenData.key, tweenData.start);
3739

3840
return TWEEN_CONST.PLAYING_BACKWARD;
@@ -71,9 +73,11 @@ var SetStateFromEnd = function (tween, tweenData, diff)
7173
onRepeat.func.apply(onRepeat.scope, onRepeat.params);
7274
}
7375

76+
// console.log('SetStateFromEnd-b', tweenData.start, tweenData.end);
77+
7478
tweenData.start = tweenData.getStartValue(tweenData.target, tweenData.key, tweenData.start);
7579

76-
tweenData.end = tweenData.getEndValue(tweenData.target, tweenData.key, tweenData.end);
80+
tweenData.end = tweenData.getEndValue(tweenData.target, tweenData.key, tweenData.start);
7781

7882
// Delay?
7983
if (tweenData.repeatDelay > 0)
@@ -129,7 +133,9 @@ var SetStateFromStart = function (tween, tweenData, diff)
129133
onRepeat.func.apply(onRepeat.scope, onRepeat.params);
130134
}
131135

132-
tweenData.end = tweenData.getEndValue(tweenData.target, tweenData.key, tweenData.end);
136+
// console.log('SetStateFromStart', tweenData.start, tweenData.end);
137+
138+
tweenData.end = tweenData.getEndValue(tweenData.target, tweenData.key, tweenData.start);
133139

134140
// Delay?
135141
if (tweenData.repeatDelay > 0)

0 commit comments

Comments
 (0)