Fixed issue with multiple "texture not bound to unit X" webgl warning

Author: bitnenfer

src/pixi/renderers/webgl/shaders/PixiFastShader.js

@@ -125,14 +125,17 @@ PIXI.PixiFastShader.prototype.init = function () {
     this.uSampler = gl.getUniformLocation(program, 'uSamplerArray[0]');
 
     var indices = [];
+    // HACK: we bind an empty texture to avoid WebGL warning spam.
+    var tempTexture = gl.createTexture();
+    gl.activeTexture(gl.TEXTURE0);
+    gl.bindTexture(gl.TEXTURE_2D, tempTexture);
+    gl.texImage2D(gl.TEXTURE_2D, 0, gl.RGB, 1, 1, 0, gl.RGB, gl.UNSIGNED_BYTE, null);
     for (var i = 0; i < this.MAX_TEXTURES; ++i) {
+        gl.activeTexture(gl.TEXTURE0 + i);
+        gl.bindTexture(gl.TEXTURE_2D, tempTexture);
         indices.push(i);
     }
-    // NOTE:!!!
-    // If textures are not bound
-    // then we'll get a bunch of warnings like:
-    // "WARNING: there is no texture bound to the unit X"
-    // Don't be scared, everything will be alright.
+    gl.activeTexture(gl.TEXTURE0);
     gl.uniform1iv(this.uSampler, indices);
 
     this.projectionVector = gl.getUniformLocation(program, 'projectionVector');

src/pixi/renderers/webgl/shaders/PixiShader.js

@@ -121,14 +121,17 @@ PIXI.PixiShader.prototype.init = function()
     this.aTextureIndex = gl.getAttribLocation(program, 'aTextureIndex');
 
     var indices = [];
+    // HACK: we bind an empty texture to avoid WebGL warning spam.
+    var tempTexture = gl.createTexture();
+    gl.activeTexture(gl.TEXTURE0);
+    gl.bindTexture(gl.TEXTURE_2D, tempTexture);
+    gl.texImage2D(gl.TEXTURE_2D, 0, gl.RGB, 1, 1, 0, gl.RGB, gl.UNSIGNED_BYTE, null);
     for (var i = 0; i < this.MAX_TEXTURES; ++i) {
+        gl.activeTexture(gl.TEXTURE0 + i);
+        gl.bindTexture(gl.TEXTURE_2D, tempTexture);
         indices.push(i);
     }
-    // NOTE:!!!
-    // If textures are not bound
-    // then we'll get a bunch of warnings like:
-    // "WARNING: there is no texture bound to the unit X"
-    // Don't be scared, everything will be alright.
+    gl.activeTexture(gl.TEXTURE0);
     gl.uniform1iv(this.uSamplerArray, indices);
 
     // Begin worst hack eva //

src/pixi/renderers/webgl/shaders/StripShader.js

@@ -111,14 +111,17 @@ PIXI.StripShader.prototype.init = function()
     this.uSampler = gl.getUniformLocation(program, 'uSamplerArray[0]');
 
     var indices = [];
+    // HACK: we bind an empty texture to avoid WebGL warning spam.
+    var tempTexture = gl.createTexture();
+    gl.activeTexture(gl.TEXTURE0);
+    gl.bindTexture(gl.TEXTURE_2D, tempTexture);
+    gl.texImage2D(gl.TEXTURE_2D, 0, gl.RGB, 1, 1, 0, gl.RGB, gl.UNSIGNED_BYTE, null);
     for (var i = 0; i < this.MAX_TEXTURES; ++i) {
+        gl.activeTexture(gl.TEXTURE0 + i);
+        gl.bindTexture(gl.TEXTURE_2D, tempTexture);
         indices.push(i);
     }
-    // NOTE:!!!
-    // If textures are not bound
-    // then we'll get a bunch of warnings like:
-    // "WARNING: there is no texture bound to the unit X"
-    // Don't be scared, everything will be alright.
+    gl.activeTexture(gl.TEXTURE0);
     gl.uniform1iv(this.uSampler, indices);
 
     this.projectionVector = gl.getUniformLocation(program, 'projectionVector');

src/pixi/renderers/webgl/utils/WebGLSpriteBatch.js

@@ -225,10 +225,10 @@ PIXI.WebGLSpriteBatch.prototype.render = function (sprite, matrix) {
     var baseTexture = texture.baseTexture;
     var gl = this.gl;
     if (this.textureArray[baseTexture.textureIndex] != baseTexture) {
+        this.flush();
         gl.activeTexture(gl.TEXTURE0 + baseTexture.textureIndex);
         gl.bindTexture(gl.TEXTURE_2D, baseTexture._glTextures[gl.id]);
         this.textureArray[baseTexture.textureIndex] = baseTexture;
-        this.flush();
     }
 
     //  They provided an alternative rendering matrix, so use it