Merge pull request phaserjs#4872 from samme/fix/timeline-callback-params

photonstorm · web-flow · commit 6f8db0774bdc · 2019-11-20T12:32:26.000Z
Fix bad parameter in Timeline callbacks and events
diff --git a/src/tweens/Timeline.js b/src/tweens/Timeline.js
@@ -279,12 +279,10 @@ var Timeline = new Class({
      */
     dispatchTimelineEvent: function (event, callback)
     {
-        this.emit(event, this, this.targets);
+        this.emit(event, this);
 
         if (callback)
         {
-            callback.params[1] = this.targets;
-
             callback.func.apply(callback.scope, callback.params);
         }
     },

Original file line number	Diff line number	Diff line change
`@@ -279,12 +279,10 @@ var Timeline = new Class({`
`279`	`279`	`*/`
`280`	`280`	`dispatchTimelineEvent: function (event, callback)`
`281`	`281`	`{`
`282`		`- this.emit(event, this, this.targets);`
	`282`	`+ this.emit(event, this);`
`283`	`283`
`284`	`284`	`if (callback)`
`285`	`285`	`{`
`286`		`- callback.params[1] = this.targets;`
`287`		`-`
`288`	`286`	`callback.func.apply(callback.scope, callback.params);`
`289`	`287`	`}`
`290`	`288`	`},`