The Gamepad Axis getValue method now correctly applies the threshold and zeroes out the returned value.

Author: photonstorm

CHANGELOG.md

@@ -26,6 +26,7 @@ being passed to the simulation. The default value is 1 to remain consistent with
 * The RenderTexture now uses the ComputedSize component instead of Size (which requires a frame), allowing calls to getBounds to work. Fix #3451 (thanks @kuoruan)
 * PathFollower.start has been renamed to `startFollow`, but PathFollower.setPath was still using `PathFollower.start` (thanks @samid737)
 * BaseSoundManager.rate and BaseSoundManager.detune would incorrectly called `setRate` on its sounds, instead of `calculateRate`.
+* The Gamepad Axis `getValue` method now correctly applies the threshold and zeroes out the returned value.
 
 ### Updates
 
@@ -36,6 +37,7 @@ being passed to the simulation. The default value is 1 to remain consistent with
 * Renamed the Camera Controls module exports for `Fixed` to `FixedKeyControl` and `Smoothed` to `SmoothedKeyControl` to match the class names. Fix #3463 (thanks @seivan)
 * The ComputedSize Component now has `setSize` and `setDisplaySize` methods. This component is used for Game Objects that have a non-texture based size.
 * The GamepadManager now extends EventEmitter directly, just like the KeyboardManager does.
+* The Gamepad Axis threshold has been increased from 0.05 to 0.1.
 
 Also, my thanks to the following for helping with the Phaser 3 Examples, either by reporting errors or fixing them: @gabegordon @melissaelopez @samid737 @nbs @tgrajewski
 

src/input/gamepad/Axis.js

@@ -52,7 +52,8 @@ var Axis = new Class({
         this.index = index;
 
         /**
-         * Between -1 and 1 with 0 being dead center.
+         * The raw axis value, between -1 and 1 with 0 being dead center.
+         * Use the method `getValue` to get a normalized value with the threshold applied.
          *
          * @name Phaser.Input.Gamepad.Axis#value
          * @type {float}
@@ -62,14 +63,14 @@ var Axis = new Class({
         this.value = 0;
 
         /**
-         * Movement tolerance threshold.
+         * Movement tolerance threshold below which axis values are ignored in `getValue`.
          *
          * @name Phaser.Input.Gamepad.Axis#threshold
          * @type {float}
-         * @default 0.05
+         * @default 0.1
          * @since 3.0.0
          */
-        this.threshold = 0.05;
+        this.threshold = 0.1;
     },
 
     /**
@@ -95,14 +96,7 @@ var Axis = new Class({
      */
     getValue: function ()
     {
-        var percentage = (Math.abs(this.value) - this.threshold) / (1 - this.threshold);
-
-        if (percentage < 0)
-        {
-            percentage = 0;
-        }
-
-        return percentage * (this.value > 0 ? 1 : -1);
+        return (Math.abs(this.value) < this.threshold) ? 0 : this.value;
     }
 
 });

src/input/gamepad/Gamepad.js

@@ -134,8 +134,10 @@ var Gamepad = new Class({
             {
                 axes[i] = new Axis(this, i);
             }
-
-            axes[i].update(axisData);
+            else
+            {
+                axes[i].update(axisData);
+            }
         }
     }