Skip to content

Commit 7ee1564

Browse files
committed
Signal.removeAll would ignore the context parameter and remove all bindings regardless (thanks @alect phaserjs#1168)
1 parent 55400ce commit 7ee1564

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,7 @@ Version 2.1.0 - "Cairhien" - -in development-
182182
* Tween.generateData would skip the end values in the data array. They are now included as the object in the final array element.
183183
* Rectangle.bottom setter swapped the order of the calculation (thanks @JakeCoxon #1165)
184184
* Phaser.Text wouldn't render the text to its local canvas if you passed the text on the constructor and didn't add it to the display list. If a string is given it now updates the local canvas on creation.
185+
* Signal.removeAll would ignore the context parameter and remove all bindings regardless (thanks @alect #1168)
185186

186187
### p2.js 0.6.0 Changes and New Features
187188

src/core/Signal.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,10 @@ Phaser.Signal.prototype = {
257257
}
258258
}
259259

260-
this._bindings.length = 0;
260+
if (!context)
261+
{
262+
this._bindings.length = 0;
263+
}
261264

262265
},
263266

0 commit comments

Comments
 (0)