Fill update: jsdocs & allow fill to update tile collisions + faces

Author: mikewesthad

v3/src/gameobjects/tilemap/Tilemap.js

@@ -209,13 +209,13 @@ var Tilemap = new Class({
         this.scene = undefined;
     },
 
-    fill: function (index, tileX, tileY, width, height, layer)
+    fill: function (index, tileX, tileY, width, height, recalculateFaces, layer)
     {
         layer = this.getLayer(layer);
         if (this._isStaticCall(layer, 'fill')) { return this; }
         if (layer !== null)
         {
-            TilemapComponents.Fill(index, tileX, tileY, width, height, layer);
+            TilemapComponents.Fill(index, tileX, tileY, width, height, recalculateFaces, layer);
         }
         return this;
     },

v3/src/gameobjects/tilemap/components/Fill.js

@@ -1,12 +1,46 @@
 var GetTilesWithin = require('./GetTilesWithin');
+var CalculateFacesWithin = require('./CalculateFacesWithin');
+
+/**
+ * Sets the tiles in the given rectangular area (in tile coordinates) with the specified index.
+ * Tiles will be set to collide if the given index is a colliding index. Interesting tile faces in
+ * the region will be recalculated.
+ *
+ * @param {number} index - [description]
+ * @param {number} tileX - [description]
+ * @param {number} tileY - [description]
+ * @param {number} width - [description]
+ * @param {number} height - [description]
+ * @param {boolean} [recalculateFaces=true] - [description]
+ * @param {LayerData} layer - [description]
+ */
 
 // Fills indices, not other properties. Does not modify collisions. Matches v2 functionality.
-var Fill = function (index, tileX, tileY, width, height, layer)
+var Fill = function (index, tileX, tileY, width, height, recalculateFaces, layer)
 {
+    if (recalculateFaces === undefined) { recalculateFaces = true; }
+
+    var doesIndexCollide = (layer.collideIndexes.indexOf(index) !== -1);
+
     var tiles = GetTilesWithin(tileX, tileY, width, height, null, layer);
     for (var i = 0; i < tiles.length; i++)
     {
         tiles[i].index = index;
+
+        if (doesIndexCollide)
+        {
+            tiles[i].setCollision(true);
+        }
+        else
+        {
+            tiles[i].resetCollision();
+        }
+    }
+
+    if (recalculateFaces)
+    {
+        // Recalculate the faces within the area and neighboring tiles
+        CalculateFacesWithin(tileX - 1, tileY - 1, width + 2, height + 2, layer);
     }
 };
 

v3/src/gameobjects/tilemap/dynamiclayer/DynamicTilemapLayer.js

@@ -76,9 +76,9 @@ var DynamicTilemapLayer = new Class({
         GameObject.prototype.destroy.call(this);
     },
 
-    fill: function (index, tileX, tileY, width, height)
+    fill: function (index, tileX, tileY, width, height, recalculateFaces)
     {
-        TilemapComponents.Fill(index, tileX, tileY, width, height, this.layer);
+        TilemapComponents.Fill(index, tileX, tileY, width, height, recalculateFaces, this.layer);
         return this;
     },