Fixed light distance and max test

photonstorm · photonstorm · commit 8174ec2daf8e · 2020-12-03T11:11:41.000Z
diff --git a/src/gameobjects/lights/LightsManager.js b/src/gameobjects/lights/LightsManager.js
@@ -163,7 +163,7 @@ var LightsManager = new Class({
             }
         }
 
-        if (visibleLights > this.maxLights)
+        if (visibleLights.length > this.maxLights)
         {
             //  We've got too many lights, so sort by distance from camera and cull those far away
             //  This isn't ideal because it doesn't factor in the radius of the lights, but it'll do for now
@@ -181,7 +181,7 @@ var LightsManager = new Class({
 
     sortByDistance: function (a, b)
     {
-        return (a.distance < b.distance);
+        return (a.distance >= b.distance);
     },
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ var LightsManager = new Class({`
`163`	`163`	`}`
`164`	`164`	`}`
`165`	`165`
`166`		`- if (visibleLights > this.maxLights)`
	`166`	`+ if (visibleLights.length > this.maxLights)`
`167`	`167`	`{`
`168`	`168`	`// We've got too many lights, so sort by distance from camera and cull those far away`
`169`	`169`	`// This isn't ideal because it doesn't factor in the radius of the lights, but it'll do for now`
`@@ -181,7 +181,7 @@ var LightsManager = new Class({`
`181`	`181`
`182`	`182`	`sortByDistance: function (a, b)`
`183`	`183`	`{`
`184`		`- return (a.distance < b.distance);`
	`184`	`+ return (a.distance >= b.distance);`
`185`	`185`	`},`
`186`	`186`
`187`	`187`	`/**`