Game.update could call updateLogic multiple times in a single frame when catching up with slow device frame rates. This would cause Tweens to advance at twice the speed they should have done (thanks @mkristo)

Time.desiredFpsMult is a pre-calculated multiplier used in Game.update.

Time.refresh updates the `Time.time` and `Time.elapsedMS` values and is called automatically by Game.update.

Author: photonstorm

README.md

@@ -275,13 +275,16 @@ If you are an exceptional JavaScript developer and would like to join the Phaser
 * Time.desiredFps has moved to a getter / setter.
 * Time.physicsElapsed and Time.physicsElapsedMS are no longer calculated every frame, but only when the desiredFps is changed.
 * Time.update has been streamlined and the `updateSetTimeout` and `updateRAF` methods merged and duplicate code removed.
+* Time.desiredFpsMult is a pre-calculated multiplier used in Game.update.
+* Time.refresh updates the `Time.time` and `Time.elapsedMS` values and is called automatically by Game.update.
 
 ### Bug Fixes
 
 * Loader.bitmapFont wouldn't automatically set the `atlasURL` value if just the key was given.
 * The Loader would put the baseURL and/or path in front of `data:` and `blob` URLs (thanks @rblopes #2044)
 * When the Text width was being calculated it would add the `strokeThickness` value twice, causing an alignment offset (thanks @nickryall #2039)
 * Sound.onEndedHandler has a fix for AudioBufferSourceNode listener memory leak (thanks @Pappa #2069)
+* Game.update could call `updateLogic` multiple times in a single frame when catching up with slow device frame rates. This would cause Tweens to advance at twice the speed they should have done (thanks @mkristo)
 
 For changes in previous releases please see the extensive [Version History](https://github.com/photonstorm/phaser/blob/master/CHANGELOG.md).
 

src/core/Game.js

@@ -785,7 +785,7 @@ Phaser.Game.prototype = {
 
         if (this._kickstart)
         {
-            this.updateLogic(1.0 / this.time.desiredFps);
+            this.updateLogic(this.time.desiredFpsMult);
 
             //  Sync the scene graph after _every_ logic update to account for moved game objects                
             this.stage.updateTransform();
@@ -805,7 +805,7 @@ Phaser.Game.prototype = {
             if (this.time.time > this._nextFpsNotification)
             {
                 // only permit one fps notification per 10 seconds
-                this._nextFpsNotification = this.time.time + 1000 * 10;
+                this._nextFpsNotification = this.time.time + 10000;
 
                 // dispatch the notification signal
                 this.fpsProblemNotifier.dispatch();
@@ -842,7 +842,7 @@ Phaser.Game.prototype = {
                 this._deltaTime -= slowStep;
                 this.currentUpdateID = count;
 
-                this.updateLogic(1.0 / this.time.desiredFps);
+                this.updateLogic(this.time.desiredFpsMult);
 
                 //  Sync the scene graph after _every_ logic update to account for moved game objects
                 this.stage.updateTransform();
@@ -904,7 +904,7 @@ Phaser.Game.prototype = {
 
             this.state.update();
             this.stage.update();
-            this.tweens.update(timeStep);
+            this.tweens.update();
             this.sound.update();
             this.input.update();
             this.physics.update();

src/time/Time.js

@@ -99,6 +99,13 @@ Phaser.Time = function (game) {
     */
     this.physicsElapsedMS = 0;
 
+    /**
+    * The desiredFps multiplier as used by Game.update.
+    * @property {integer} desiredFpsMult
+    * @protected
+    */
+    this.desiredFpsMult = 1.0 / 60;
+
     /**
     * The desired frame rate of the game.
     *
@@ -329,6 +336,11 @@ Phaser.Time.prototype = {
 
     },
 
+    /**
+    * Refreshes the Time.time and Time.elapsedMS properties from the system clock.
+    *
+    * @method Phaser.Time#refresh
+    */
     refresh: function () {
 
         //  Set to the old Date.now value
@@ -441,7 +453,7 @@ Phaser.Time.prototype = {
         this._elapsedAccumulator += this.elapsed;
 
         // occasionally recalculate the suggestedFps based on the accumulated elapsed time
-        if (this._frameCount >= this.desiredFps * 2)
+        if (this._frameCount >= this._desiredFps * 2)
         {
             // this formula calculates suggestedFps in multiples of 5 fps
             this.suggestedFps = Math.floor(200 / (this._elapsedAccumulator / this._frameCount)) * 5;
@@ -582,6 +594,8 @@ Object.defineProperty(Phaser.Time.prototype, "desiredFps", {
 
         this.physicsElapsedMS = this.physicsElapsed * 1000;
 
+        this.desiredFpsMult = 1.0 / value;
+
     }
 
 });

src/tween/TweenData.js

@@ -240,13 +240,6 @@ Phaser.TweenData.prototype = {
 
         this.startTime = this.game.time.time + this.delay;
 
-        //  DEBUG
-        this.realStart = Date.now();
-        this.totalElapsedMs = 0;
-
-        // console.log('startTime', this.startTime);
-        // console.log('realStart', this.realStart);
-
         if (this.parent.reverse)
         {
             this.dt = this.duration;
@@ -382,13 +375,6 @@ Phaser.TweenData.prototype = {
 
         this.percent = this.dt / this.duration;
 
-        this.totalElapsedMs = (this.totalElapsedMs || 0) + this.game.time.elapsedMS;
-
-        // if (this.percent === 1)
-        // {
-            // console.log("ElapsedTime", this.totalElapsedMs, Date.now() - this.realStart);
-        // }
-
         this.value = this.easingFunction(this.percent);
 
         for (var property in this.vEnd)