Skip to content

Commit 90e6637

Browse files
committed
Particle Renderers now bail out early if emitter is empty
1 parent a98b354 commit 90e6637

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

v3/src/gameobjects/emitter/ParticleEmitterCanvasRenderer.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@ var GameObject = require('../GameObject');
22

33
var ParticleEmitterCanvasRenderer = function (renderer, emitter, interpolationPercentage, camera)
44
{
5+
if (emitter.isEmpty() || GameObject.RENDER_MASK !== emitter.renderFlags || (emitter.cameraFilter > 0 && (emitter.cameraFilter & camera._id)))
6+
{
7+
return;
8+
}
9+
510
var particles = emitter.alive;
611
var length = particles.length;
712
var ctx = renderer.currentContext;
@@ -17,11 +22,6 @@ var ParticleEmitterCanvasRenderer = function (renderer, emitter, interpolationPe
1722
var cameraScrollX = camera.scrollX * emitter.scrollFactorX;
1823
var cameraScrollY = camera.scrollY * emitter.scrollFactorY;
1924

20-
if (length === 0 || GameObject.RENDER_MASK !== emitter.renderFlags || (emitter.cameraFilter > 0 && (emitter.cameraFilter & camera._id)))
21-
{
22-
return;
23-
}
24-
2525
if (renderer.currentBlendMode !== emitter.blendMode)
2626
{
2727
renderer.currentBlendMode = emitter.blendMode;

v3/src/gameobjects/emitter/ParticleEmitterWebGLRenderer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ var GameObject = require('../GameObject');
22

33
var ParticleEmitterWebGLRenderer = function (renderer, emitter, interpolationPercentage, camera)
44
{
5-
if (GameObject.RENDER_MASK !== emitter.renderFlags || (emitter.cameraFilter > 0 && (emitter.cameraFilter & camera._id)))
5+
if (emitter.isEmpty() || GameObject.RENDER_MASK !== emitter.renderFlags || (emitter.cameraFilter > 0 && (emitter.cameraFilter & camera._id)))
66
{
77
return;
88
}

0 commit comments

Comments
 (0)