Transform.getWorldTransformMatrix has been recoded to iterate the transform parents correctly, applying the matrix multiplications as it goes. This (along with some changes in the Input Manager) fix the issue with Game Objects inside of Containers failing hit tests between certain angles. Fix phaserjs#3920

Author: photonstorm

src/gameobjects/components/Transform.js

@@ -427,12 +427,14 @@ var Transform = {
      * @since 3.4.0
      *
      * @param {Phaser.GameObjects.Components.TransformMatrix} [tempMatrix] - The matrix to populate with the values from this Game Object.
+     * @param {Phaser.GameObjects.Components.TransformMatrix} [parentMatrix] - A temporary matrix to hold parent values during the calculations.
      *
      * @return {Phaser.GameObjects.Components.TransformMatrix} The populated Transform Matrix.
      */
-    getWorldTransformMatrix: function (tempMatrix)
+    getWorldTransformMatrix: function (tempMatrix, parentMatrix)
     {
         if (tempMatrix === undefined) { tempMatrix = new TransformMatrix(); }
+        if (parentMatrix === undefined) { parentMatrix = new TransformMatrix(); }
 
         var parent = this.parentContainer;
 
@@ -441,31 +443,17 @@ var Transform = {
             return this.getLocalTransformMatrix(tempMatrix);
         }
 
-        var parents = [];
-        
+        tempMatrix.applyITRS(this.x, this.y, this._rotation, this._scaleX, this._scaleY);
+
         while (parent)
         {
-            parents.unshift(parent);
-            parent = parent.parentContainer;
-        }
+            parentMatrix.applyITRS(parent.x, parent.y, parent._rotation, parent._scaleX, parent._scaleY);
 
-        tempMatrix.loadIdentity();
+            parentMatrix.multiply(tempMatrix, tempMatrix);
 
-        var length = parents.length;
-        
-        for (var i = 0; i < length; ++i)
-        {
-            parent = parents[i];
-
-            tempMatrix.translate(parent.x, parent.y);
-            tempMatrix.rotate(parent.rotation);
-            tempMatrix.scale(parent.scaleX, parent.scaleY);
+            parent = parent.parentContainer;
         }
 
-        tempMatrix.translate(this.x, this.y);
-        tempMatrix.rotate(this._rotation);
-        tempMatrix.scale(this._scaleX, this._scaleY);
-
         return tempMatrix;
     }
 

src/gameobjects/container/Container.js

@@ -438,6 +438,7 @@ var Container = new Class({
 
     /**
      * Returns the world transform matrix as used for Bounds checks.
+     * 
      * The returned matrix is temporal and shouldn't be stored.
      *
      * @method Phaser.GameObjects.Container#getBoundsTransformMatrix
@@ -447,7 +448,7 @@ var Container = new Class({
      */
     getBoundsTransformMatrix: function ()
     {
-        return this.getWorldTransformMatrix(this.tempTransformMatrix);
+        return this.getWorldTransformMatrix(this.tempTransformMatrix, this.localTransform);
     },
 
     /**

src/math/TransformXY.js

@@ -28,31 +28,20 @@ var TransformXY = function (x, y, positionX, positionY, rotation, scaleX, scaleY
 {
     if (output === undefined) { output = new Vector2(); }
 
-    //  ITRS
+    var radianSin = Math.sin(rotation);
+    var radianCos = Math.cos(rotation);
 
-    var sr = Math.sin(-rotation);
-    var cr = Math.cos(-rotation);
-
-    var a = cr * scaleX;
-    var b = -sr * scaleX;
-    var c = sr * scaleY;
-    var d = cr * scaleY;
+    // Rotate and Scale
+    var a = radianCos * scaleX;
+    var b = radianSin * scaleX;
+    var c = -radianSin * scaleY;
+    var d = radianCos * scaleY;
 
     //  Invert
+    var id = 1 / ((a * d) + (c * -b));
 
-    var n = a * d - b * c;
-
-    var m0 = d / n;
-    var m1 = -b / n;
-    var m2 = -c / n;
-    var m3 = a / n;
-    var m4 = (c * positionY - d * positionX) / n;
-    var m5 = -(a * positionY - b * positionX) / n;
-
-    //  Transform
-
-    output.x = x * m0 + y * m2 + m4;
-    output.y = x * m1 + y * m3 + m5;
+    output.x = (d * id * x) + (-c * id * y) + (((positionY * c) - (positionX * d)) * id);
+    output.y = (a * id * y) + (-b * id * x) + (((-positionY * a) + (positionX * b)) * id);
 
     return output;
 };