Create 1 shader per light count. Avoids all pointless iteration within the shaders

Author: photonstorm

src/renderer/webgl/pipelines/LightPipeline.js

@@ -72,7 +72,19 @@ var LightPipeline = new Class({
     {
         LIGHT_COUNT = config.game.renderer.config.maxLights;
 
-        config.fragShader = GetFastValue(config, 'fragShader', LightShaderSourceFS).replace('%LIGHT_COUNT%', LIGHT_COUNT.toString());
+        var fragShader = GetFastValue(config, 'fragShader', LightShaderSourceFS);
+
+        var shaders = [];
+
+        for (var i = 1; i <= LIGHT_COUNT; i++)
+        {
+            shaders.push({
+                name: 'lights' + i,
+                fragShader: fragShader.replace('%LIGHT_COUNT%', i.toString())
+            });
+        }
+
+        config.shaders = shaders;
 
         MultiPipeline.call(this, config);
 
@@ -125,15 +137,12 @@ var LightPipeline = new Class({
         gl.texImage2D(gl.TEXTURE_2D, 0, gl.RGBA, 1, 1, 0, gl.RGBA, gl.UNSIGNED_BYTE, new Uint8Array([ 127, 127, 255, 255 ]));
 
         this.defaultNormalMap = { glTexture: tempTexture };
-    },
-
-    onActive: function ()
-    {
-        this.renderer.resetTextures();
 
-        this.set1i('uMainSampler', 0);
-        this.set1i('uNormSampler', 1);
-        this.set2f('uResolution', this.width / 2, this.height / 2);
+        //  Set the lights shaders
+        for (var i = 0; i < this.shaders.length; i++)
+        {
+            this['lightShader' + (i + 1)] = this.shaders[i];
+        }
     },
 
     /**
@@ -150,28 +159,34 @@ var LightPipeline = new Class({
     {
         var lightManager = scene.sys.lights;
 
-        if (!lightManager || lightManager.lights.length <= 0 || !lightManager.active)
+        if (!lightManager || !lightManager.active)
         {
             return;
         }
 
         var lights = lightManager.getLights(camera);
+        var lightsCount = lights.length;
 
-        var renderer = this.renderer;
-        var cameraMatrix = camera.matrix;
-        var height = renderer.height;
-        var i;
-
-        for (i = 0; i < LIGHT_COUNT; i++)
+        if (lightsCount === 0)
         {
-            this.set1f('uLights[' + i + '].radius', 0);
+            return;
         }
 
-        this.set4f('uCamera', camera.x, camera.y, camera.rotation, camera.zoom);
+        //  Ok, we're good to go ...
+        this.setShader(this['lightShader' + lightsCount], true);
+
+        var i;
+        var renderer = this.renderer;
+        var height = renderer.height;
+        var cameraMatrix = camera.matrix;
 
+        this.set1i('uMainSampler', 0);
+        this.set1i('uNormSampler', 1);
+        this.set2f('uResolution', this.width / 2, this.height / 2);
+        this.set4f('uCamera', camera.x, camera.y, camera.rotation, camera.zoom);
         this.set3f('uAmbientLightColor', lightManager.ambientColor.r, lightManager.ambientColor.g, lightManager.ambientColor.b);
 
-        for (i = 0; i < lights.length; i++)
+        for (i = 0; i < lightsCount; i++)
         {
             var light = lights[i].light;
             var color = light.color;