Skip to content

Commit 9cd4c1b

Browse files
committed
Refactored to use local vars
1 parent d844402 commit 9cd4c1b

1 file changed

Lines changed: 55 additions & 34 deletions

File tree

src/scene/Systems.js

Lines changed: 55 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -374,13 +374,15 @@ var Systems = new Class({
374374
*/
375375
step: function (time, delta)
376376
{
377-
this.events.emit(Events.PRE_UPDATE, time, delta);
377+
var events = this.events;
378378

379-
this.events.emit(Events.UPDATE, time, delta);
379+
events.emit(Events.PRE_UPDATE, time, delta);
380+
381+
events.emit(Events.UPDATE, time, delta);
380382

381383
this.sceneUpdate.call(this.scene, time, delta);
382384

383-
this.events.emit(Events.POST_UPDATE, time, delta);
385+
events.emit(Events.POST_UPDATE, time, delta);
384386
},
385387

386388
/**
@@ -440,13 +442,16 @@ var Systems = new Class({
440442
*/
441443
pause: function (data)
442444
{
445+
var events = this.events;
446+
var settings = this.settings;
447+
443448
if (this.settings.active)
444449
{
445-
this.settings.status = CONST.PAUSED;
450+
settings.status = CONST.PAUSED;
446451

447-
this.settings.active = false;
452+
settings.active = false;
448453

449-
this.events.emit(Events.PAUSE, this, data);
454+
events.emit(Events.PAUSE, this, data);
450455
}
451456

452457
return this;
@@ -465,13 +470,16 @@ var Systems = new Class({
465470
*/
466471
resume: function (data)
467472
{
473+
var events = this.events;
474+
var settings = this.settings;
475+
468476
if (!this.settings.active)
469477
{
470-
this.settings.status = CONST.RUNNING;
478+
settings.status = CONST.RUNNING;
471479

472-
this.settings.active = true;
480+
settings.active = true;
473481

474-
this.events.emit(Events.RESUME, this, data);
482+
events.emit(Events.RESUME, this, data);
475483
}
476484

477485
return this;
@@ -495,12 +503,15 @@ var Systems = new Class({
495503
*/
496504
sleep: function (data)
497505
{
498-
this.settings.status = CONST.SLEEPING;
506+
var events = this.events;
507+
var settings = this.settings;
499508

500-
this.settings.active = false;
501-
this.settings.visible = false;
509+
settings.status = CONST.SLEEPING;
502510

503-
this.events.emit(Events.SLEEP, this, data);
511+
settings.active = false;
512+
settings.visible = false;
513+
514+
events.emit(Events.SLEEP, this, data);
504515

505516
return this;
506517
},
@@ -518,18 +529,19 @@ var Systems = new Class({
518529
*/
519530
wake: function (data)
520531
{
532+
var events = this.events;
521533
var settings = this.settings;
522534

523535
settings.status = CONST.RUNNING;
524536

525537
settings.active = true;
526538
settings.visible = true;
527539

528-
this.events.emit(Events.WAKE, this, data);
540+
events.emit(Events.WAKE, this, data);
529541

530542
if (settings.isTransition)
531543
{
532-
this.events.emit(Events.TRANSITION_WAKE, settings.transitionFrom, settings.transitionDuration);
544+
events.emit(Events.TRANSITION_WAKE, settings.transitionFrom, settings.transitionDuration);
533545
}
534546

535547
return this;
@@ -698,21 +710,24 @@ var Systems = new Class({
698710
*/
699711
start: function (data)
700712
{
713+
var events = this.events;
714+
var settings = this.settings;
715+
701716
if (data)
702717
{
703-
this.settings.data = data;
718+
settings.data = data;
704719
}
705720

706-
this.settings.status = CONST.START;
721+
settings.status = CONST.START;
707722

708-
this.settings.active = true;
709-
this.settings.visible = true;
723+
settings.active = true;
724+
settings.visible = true;
710725

711726
// For plugins to listen out for
712-
this.events.emit(Events.START, this);
727+
events.emit(Events.START, this);
713728

714729
// For user-land code to listen out for
715-
this.events.emit(Events.READY, this, data);
730+
events.emit(Events.READY, this, data);
716731
},
717732

718733
/**
@@ -730,17 +745,20 @@ var Systems = new Class({
730745
*/
731746
shutdown: function (data)
732747
{
733-
this.events.off(Events.TRANSITION_INIT);
734-
this.events.off(Events.TRANSITION_START);
735-
this.events.off(Events.TRANSITION_COMPLETE);
736-
this.events.off(Events.TRANSITION_OUT);
748+
var events = this.events;
749+
var settings = this.settings;
737750

738-
this.settings.status = CONST.SHUTDOWN;
751+
events.off(Events.TRANSITION_INIT);
752+
events.off(Events.TRANSITION_START);
753+
events.off(Events.TRANSITION_COMPLETE);
754+
events.off(Events.TRANSITION_OUT);
739755

740-
this.settings.active = false;
741-
this.settings.visible = false;
756+
settings.status = CONST.SHUTDOWN;
742757

743-
this.events.emit(Events.SHUTDOWN, this, data);
758+
settings.active = false;
759+
settings.visible = false;
760+
761+
events.emit(Events.SHUTDOWN, this, data);
744762
},
745763

746764
/**
@@ -755,14 +773,17 @@ var Systems = new Class({
755773
*/
756774
destroy: function ()
757775
{
758-
this.settings.status = CONST.DESTROYED;
776+
var events = this.events;
777+
var settings = this.settings;
778+
779+
settings.status = CONST.DESTROYED;
759780

760-
this.settings.active = false;
761-
this.settings.visible = false;
781+
settings.active = false;
782+
settings.visible = false;
762783

763-
this.events.emit(Events.DESTROY, this);
784+
events.emit(Events.DESTROY, this);
764785

765-
this.events.removeAllListeners();
786+
events.removeAllListeners();
766787

767788
var props = [ 'scene', 'game', 'anims', 'cache', 'plugins', 'registry', 'sound', 'textures', 'add', 'camera', 'displayList', 'events', 'make', 'scenePlugin', 'updateList' ];
768789

0 commit comments

Comments
 (0)