Fixed Game.destroy

Author: photonstorm

CHANGELOG.md

@@ -45,6 +45,7 @@ Please see the complete JSDocs for the ScenePlugin for more details, as well as
 * Group.remove didn't check if the passed Game Object was already a member of the group and would call `removeCallback` and (if specified) `destroy` in any case. Now it does nothing if the Game Object isn't a member of the group (thanks @samme)
 * If a Group size exceeded `maxSize` (which can happen if you reduce maxSize beneath the current size), `isFull` would return false and the group could continue to grow. Now `isFull` returns true in that case (thanks @samme)
 * Camera.fadeIn following a fadeOut wouldn't work, but is now fixed as a result of the Camera effects rewrite. Fix #3527 (thanks @Jerenaux)
+* Particle Emitters with large volumes of particles would throw the error `GL_INVALID_OPERATION: Vertex buffer is not big enough for the draw call` in WebGL.
 
 ### Updates
 

src/boot/Game.js

@@ -242,6 +242,26 @@ var Game = new Class({
          */
         this.onStepCallback = NOOP;
 
+        /**
+         * Is this Game pending destroy at the end of the next frame?
+         *
+         * @name Phaser.Game#pendingDestroy
+         * @type {boolean}
+         * @private
+         * @since 3.5.0
+         */
+        this.pendingDestroy = false;
+
+        /**
+         * Remove the Canvas once the destroy is over?
+         *
+         * @name Phaser.Game#removeCanvas
+         * @type {boolean}
+         * @private
+         * @since 3.5.0
+         */
+        this.removeCanvas = false;
+
         //  Wait for the DOM Ready event, then call boot.
         DOMContentLoaded(this.boot.bind(this));
     },
@@ -354,6 +374,11 @@ var Game = new Class({
      */
     step: function (time, delta)
     {
+        if (this.pendingDestroy)
+        {
+            return this.runDestroy();
+        }
+
         //  Global Managers
 
         this.input.update(time, delta);
@@ -534,7 +559,24 @@ var Game = new Class({
      */
     destroy: function (removeCanvas)
     {
-        this.loop.destroy();
+        this.pendingDestroy = true;
+        this.removeCanvas = removeCanvas;
+
+        this.loop.stop();
+    },
+
+    /**
+     * Destroys this Phaser.Game instance, all global systems, all sub-systems and all Scenes.
+     *
+     * @method Phaser.Game#runDestroy
+     * @private
+     * @since 3.5.0
+     */
+    runDestroy: function ()
+    {
+        this.events.emit('destroy');
+
+        this.events.removeAllListeners();
 
         this.scene.destroy();
 
@@ -543,16 +585,16 @@ var Game = new Class({
             this.renderer.destroy();
         }
 
-        this.events.emit('destroy');
-
-        this.events.removeAllListeners();
-
         this.onStepCallback = null;
 
-        if (removeCanvas && this.canvas)
+        if (this.removeCanvas && this.canvas)
         {
             CanvasPool.remove(this.canvas);
         }
+
+        this.loop.destroy();
+
+        this.pendingDestroy = false;
     }
 
 });

src/scene/SceneManager.js

@@ -1480,6 +1480,8 @@ var SceneManager = new Class({
             sys.destroy();
         }
 
+        this.update = NOOP;
+
         this.scenes = [];
 
         this._pending = [];

src/scene/Systems.js

@@ -8,6 +8,7 @@ var Class = require('../utils/Class');
 var CONST = require('./const');
 var GetPhysicsPlugins = require('./GetPhysicsPlugins');
 var GetScenePlugins = require('./GetScenePlugins');
+var NOOP = require('../utils/NOOP');
 var Plugins = require('../plugins');
 var Settings = require('./Settings');